Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio Shortcode: Remove WordAds #6962

Merged
merged 1 commit into from Apr 24, 2017
Merged

Portfolio Shortcode: Remove WordAds #6962

merged 1 commit into from Apr 24, 2017

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Apr 11, 2017

With Ads enabled and using the Portfolio shortcode, ads are injected with each portfolio entry. Let's remove this.

This seeks to surgically remove the ads from this instance only purposely set on a non-default priority so we can add/remove the function with a reduced chance of interfering with other plugins or code modifying the ad run.

To test, use a shortcode like [portfolio display_types="false" include_types="contributing"].

2017-04-10 22_51_55-about brandon kraft

@kraftbj kraftbj added [Feature] Shortcodes / Embeds [Feature] WordAds [Pri] Normal [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Apr 11, 2017
@dereksmart
Copy link
Member

Yeah, that's an ugly view with so many ads.

I think this is reasonable. If people want them shown in the shortcode views they can override with the filter as described in the PR description add_filter( 'wordads_inpost_disable', '__return_false', 21 );

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 12, 2017
@jeherve jeherve modified the milestone: 4.9 Apr 24, 2017
@zinigor zinigor merged commit 7298d3a into master Apr 24, 2017
@zinigor zinigor deleted the kraftbj-patch-2 branch April 24, 2017 18:05
@zinigor zinigor removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 24, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Shortcodes / Embeds [Feature] WordAds [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants