Add external link icon to Jetpack reader feed link #2247
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Jetpack integration to add the 'activitypub-external' class to the reader feed link, and added CSS to display a dashicon after external links. This visually indicates external links in the admin interface.
pfefferle
added
the
Skip Changelog
github-actions
bot
added
the
[Focus] Compatibility
There was a problem hiding this comment.
Pull Request Overview
This PR adds visual indication for external links in the Jetpack integration by applying CSS styling to display a dashicon after external links in the admin interface.
- Updated Jetpack connection check to use the modern Manager class
- Added 'activitypub-external' class to the reader feed link
- Added CSS rule to display a dashicon after elements with the 'activitypub-external' class
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| integration/class-jetpack.php | Updated Jetpack connection detection and added CSS class to reader link |
| assets/css/activitypub-admin.css | Added CSS styling for external link icon |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Replaces the use of Automattic\Jetpack\Connection\Manager for checking user connection with Jetpack::is_connection_ready(). This simplifies the connection check and removes an unnecessary use statement.
jeherve
reviewed
Sep 30, 2025
The Reader link in the Jetpack integration now includes an aria-label attribute to improve accessibility for screen readers.
Removes the CSS-based external link icon and updates the Jetpack integration to use a Dashicons icon within the link markup. Improves accessibility by adding screen reader text indicating the link opens in a new tab.
obenland
requested changes
Sep 30, 2025
Set font size and line height for dashicons within the followings table to improve visual consistency.
obenland
approved these changes
Sep 30, 2025
pfefferle
added a commit
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Jetpack integration to add the 'activitypub-external' class to the reader feed link, and added CSS to display a dashicon after external links. This visually indicates external links in the admin interface.
Proposed changes:
Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message