Skip to content

Add external link icon to Jetpack reader feed link #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 30, 2025
Merged

Add external link icon to Jetpack reader feed link #2247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0731132
Add external link icon to Jetpack reader feed link
pfefferle Sep 30, 2025
6b9864a
Update Jetpack connection check in integration
pfefferle Sep 30, 2025
eb900bd
Add aria-label to Reader link for accessibility
pfefferle Sep 30, 2025
70ebb21
Update external link icon and accessibility in Jetpack integration
pfefferle Sep 30, 2025
f80ae3b
Adjust dashicon styles in followings table
pfefferle Sep 30, 2025
c866885
Merge branch 'trunk' into add/external-icon
pfefferle Sep 30, 2025
ad185f7
Merge branch 'trunk' into add/external-icon
pfefferle Sep 30, 2025
6cc5655
Merge branch 'trunk' into add/external-icon
pfefferle Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions assets/css/activitypub-admin.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@ summary {
transform: translateY(-30%) rotate(-135deg);
}

table.followings .dashicons {
font-size: 1em;
line-height: 1.7;
}

.activitypub-settings-accordion-trigger:active,
.activitypub-settings-accordion-trigger:hover {
background: #f6f7f7;
Expand Down
6 changes: 4 additions & 2 deletions integration/class-jetpack.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,11 @@ public static function add_reader_link( $actions, $item ) {
return array_merge(
array(
'reader' => sprintf(
'<a href="%s" target="_blank">%s</a>',
'<a href="%1$s" target="_blank">%2$s<span class="screen-reader-text"> %3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
esc_url( $url ),
esc_html__( 'View Feed', 'activitypub' )
esc_html__( 'View Feed', 'activitypub' ),
/* translators: Hidden accessibility text. */
esc_html__( '(opens in a new tab)', 'activitypub' )
),
),
$actions
Expand Down