Extend historical access API's

[LHerskind]

The historical access API's are currently taking a specific block to lookup.

pub fn prove_note_inclusion<Note, N>(
    note_with_header: Note,
    block_number: u32, // The block at which we'll prove that the note exists
    context: PrivateContext
) where Note: NoteInterface;

This is useful for when you know a specific block in the past that you want to prove upon, but less flexible when execution don't want extra inputs for block numbers, but simply to know that it is in the current state.

To add this functionality, we can use the historical_headers state directly, simply using the block_number of the header directly as well.

pub fn prove_note_inclusion<Note, N>(
    note_with_header: Note,
    context: PrivateContext
) where Note: NoteInterface;

An optimized version can be achieved by simply calling the existing api but feeding in the variable. However, this is inefficient as we are then doing an unnecessary inclusion proof of the header.

The outcome should be having two functions, such as

pub fn prove_note_inclusion_at<Note, N>(
    note_with_header: Note,
    block_number: u32, // The block at which we'll prove that the note exists
    context: PrivateContext
) where Note: NoteInterface;

pub fn prove_note_inclusion<Note, N>(
    note_with_header: Note,
    context: PrivateContext
) where Note: NoteInterface;

Tasklist

Beta Give feedback

1. Update apis in aztec-nr/aztec/src/history
2. Extend tests
3. Update read_private of stable_public_state.nr

[benesjan]

@sklppy88 please wait for this PR to be merged (should be by tomorrow)

(or base your branch on it)

[LHerskind]

From some of the discussion in #4154 the general inclusion proofs could be updated to support using the current header as well, essentially skipping the "does this header exists" in the app-circuit as the current header already goes through this check with the base

[benesjan]

Created a separate issue for this ^