refactor: toFields()/fromFields(...) methods in more classes

[benesjan]

Partially fixes #4332

The goal of this PR was to progress on nuking yarn-project/acir-simulator/src/acvm/serialize.ts and move it to the individual classes to then be able to easily test it in the classes tests and improve readability.

I didn't fully tackle the issue in this one because it was all getting too big.

[benesjan]

Current dependencies on/for this PR:

• master
  • PR refactor: toFields()/fromFields(...) methods in more classes #4335 👈
    • PR refactor: typing contents of MessageLoadOracleInputs #4351
      • PR refactor: PublicCircuitPublicInputs and PrivateCircuitPublicInputs cleanup #4360
        • PR test: testing toFields() length #4364
          • PR feat: hashing output of serialize() in noir + more tests #4365
            • PR refactor: consistent naming of serialization method #4379
              • PR refactor: call stack item cleanup #4381

This stack of pull requests is managed by Graphite.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 25.3 (+110%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit e7db0da2 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,412	179,524	716,068
l1_rollup_calldata_gas	221,692	866,524	3,448,492
l1_rollup_execution_gas	314,179	984,264	3,668,149
l2_block_processing_time_in_ms	1,165 (+1%)	4,391 (+1%)	17,324 (+1%)
note_successful_decrypting_time_in_ms	315 (+4%)	1,007 (+4%)	3,751 (+4%)
note_trial_decrypting_time_in_ms	⚠️ 25.3 (+110%)	40.3 (-57%)	148 (+5%)
l2_block_building_time_in_ms	18,230	72,580 (+1%)	290,786 (+1%)
l2_block_rollup_simulation_time_in_ms	13,083 (+1%)	51,936 (+1%)	208,661 (+1%)
l2_block_public_tx_process_time_in_ms	5,119	20,565 (+2%)	81,875 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,873 (+1%)	26,669 (+1%)
note_history_successful_decrypting_time_in_ms	2,507 (+1%)	4,608
note_history_trial_decrypting_time_in_ms	89.8 (+7%)	218 (+11%)
node_database_size_in_bytes	17,338,448	33,210,448
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	310 (+1%)	44,481	26,193
private-kernel-ordering	195 (+1%)	44,513	14,929
base-rollup	1,406	128,970	881
root-rollup	83.2 (+1%)	4,088	677
private-kernel-inner	413	71,640	26,193
public-kernel-private-input	244 (+1%)	32,615	26,193
public-kernel-non-first-iteration	243 (+1%)	32,657	26,193
merge-rollup	7.84 (+3%)	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	11.6 (+6%)	12.7 (-2%)	17.4 (+4%)	23.1 (+1%)	64.1 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.594	0.647 (+6%)	0.541 (-2%)	0.539 (+3%)	0.481 (+1%)	0.442 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	74.5	47.8 (+1%)	240 (+1%)	463	907 (+1%)	3,567 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.460	0.489	0.438 (+1%)	0.433	0.431 (+1%)	0.428
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	104 (+1%)	57.0 (+1%)	353 (+1%)	689	1,367 (+1%)	5,398
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.496 (+1%)	0.497	0.480 (+1%)	0.473	0.473 (+1%)	0.470
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.8 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.580 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,575	37,972

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	568 (+4%)	1,381 (+1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.518 (+6%)	632 (+1%)

[LHerskind]

Nice stuff. Looking solid, have added a few comments, think the serializeToFieldArray() could be used more, but it is not a dealbreaker to me.

[LHerskind]

For the functions that have getFields should we generally be using this approach instead? For some cases higher up, there was both a getFields and a toFields which both were setting the order, might be better to do it like here to not run into ordering issues.

[benesjan]

Agree, will update CallContext here and follow that approach from on.

[LHerskind]

As mentioned earlier I think we could likely be using this together with the GetFields that some of the types already had.