refactor: eth address tech debt cleanup

[benesjan]

We used to serialize EthAddress as 32 bytes because we needed that for compatibility with CBINDs. Given that we no longer use the C++ code this is no longer necessary.

Note: decided to not completely nuke EthAddress.toBuffer32() because that would require updating how we compute calldata/body hash and it makes sense to do that once we'll do that in #3938 (linked it in the issue).

[benesjan]

Current dependencies on/for this PR:

• master
  • PR refactor: eth address tech debt cleanup #4442 👈

This stack of pull requests is managed by Graphite.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 13.4 (-88%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit a6179bdb and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,636	180,516	720,036
l1_rollup_calldata_gas	222,516	871,020	3,462,696
l1_rollup_execution_gas	315,003	988,760	3,682,353
l2_block_processing_time_in_ms	1,145	4,332	17,202
note_successful_decrypting_time_in_ms	300	959 (-1%)	3,606
note_trial_decrypting_time_in_ms	⚠️ 13.4 (-88%)	91.0 (-8%)	148 (+2%)
l2_block_building_time_in_ms	17,860 (-1%)	70,716	283,819
l2_block_rollup_simulation_time_in_ms	13,048	51,633	207,803
l2_block_public_tx_process_time_in_ms	4,783 (-2%)	18,999	75,759

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,739	26,368
note_history_successful_decrypting_time_in_ms	2,308 (-3%)	4,671 (+1%)
note_history_trial_decrypting_time_in_ms	80.8 (-20%)	232 (+6%)
node_database_size_in_bytes	17,322,064	33,067,088
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	309	44,476	26,153
private-kernel-ordering	198 (-1%)	44,473	16,553
base-rollup	1,405	128,930	881
root-rollup	82.3	4,088	677
private-kernel-inner	444	71,607	26,153
public-kernel-private-input	247	32,563	26,153
public-kernel-non-first-iteration	246	32,605	26,153
merge-rollup	7.63	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	11.2 (+4%)	12.6	17.0 (+1%)	22.7	63.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.595	0.627 (+4%)	0.536	0.526 (+1%)	0.477	0.440	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	74.9 (+1%)	47.5 (-1%)	238	461	896	3,545
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.464 (+1%)	0.487 (-1%)	0.435	0.432	0.427	0.426
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	103 (-1%)	56.5	348	688	1,362	5,420 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.494	0.496	0.474	0.473	0.472 (-1%)	0.471
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.4	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.577	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	17,187	39,991

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	559	1,318

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.493 (-3%)	590

[LHerskind]

Good stuff.

[LHerskind]

👀

[LHerskind]

Interesting to see here that it could pass an AztecAddress and then directly checking that it was eth address after

[LHerskind]