Ignore repeat/reboot on dry run commands for Zypper

[benank]

If the package manager returns code 102 (REBOOT_REQUIRED) or 103 (ZYPPER_UPDATED, will need to repeat last patch installation) from a dry run command, it will get stuck in a loop. It gets stuck in a loop because although the dry run command returns a non-zero exit code indicating that a specific action needs to be taken, this action will only need to be taken once the command is actually run and does not apply for the dry run command. The dry run command is a preview of what would happen when the command is run.

For code REBOOT_REQUIRED, it breaks out of the loop because the maintenance window is exceeded.

For code ZYPPER_UPDATED, it breaks out of the loop on the second attempt because of this code:

if package_manager.get_package_manager_setting(Constants.PACKAGE_MGR_SETTING_REPEAT_PATCH_OPERATION, False):  # We should not see this again
    error_msg = "Unexpected repeated package manager update occurred. Please re-run the update deployment."
    self.status_handler.add_error_to_status(error_msg, Constants.PatchOperationErrorCodes.PACKAGE_MANAGER_FAILURE)
    raise Exception(error_msg, "[{0}]".format(Constants.ERROR_ADDED_TO_STATUS))

This PR fixes this problem by not taking any specific actions when these exit codes are returned. If one of these exit codes is returned on a dry run command, it's logged, and execution continues normally without repeating installation/rebooting.

[codecov]

Codecov Report

Merging #135 (6dd9d95) into master (3e34573) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   86.95%   87.04%   +0.09%     
==========================================
  Files          48       48              
  Lines        8230     8262      +32     
==========================================
+ Hits         7156     7192      +36     
+ Misses       1074     1070       -4     

Flag	Coverage Δ
python27	85.87% <100.00%> (+0.10%)	⬆️
python39	87.00% <100.00%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../core/src/package_managers/ZypperPackageManager.py	86.59% <100.00%> (+1.03%)	⬆️
src/core/tests/Test_ZypperPackageManager.py	96.53% <100.00%> (+0.18%)	⬆️
src/core/tests/library/LegacyEnvLayerExtensions.py	94.15% <100.00%> (+0.10%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e34573...6dd9d95. Read the comment docs.

[kjohn-msft]

Good investigation.. Please address naming and get some basic UT coverage.

[kjohn-msft]

Accidentally approved.. UT.