Only handle Zypper repeat exit code in one place #145
Conversation
benank
requested review from
a team,
kjohn-msft and
rane-rajasi
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 87.20% 87.22% +0.01%
==========================================
Files 48 48
Lines 8357 8354 -3
==========================================
- Hits 7288 7287 -1
+ Misses 1069 1067 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| if code == self.zypper_exitcode_zypper_updated: | ||
| if code == self.zypper_exitcode_zypper_updated or self.zypper_out_zypper_updated_msg in out: | ||
| self.composite_logger.log_debug( | ||
| " - Package manager update detected. Patch installation run will be repeated.") |
There was a problem hiding this comment.
Update log to One of the installed patches affects the package manager. Patch installation run will be repeated
| else: # verbose diagnostic log | ||
| self.log_success_on_invoke(code, out) | ||
|
|
||
| if code == self.zypper_exitcode_zypper_updated or code == self.zypper_exitcode_reboot_required: |
There was a problem hiding this comment.
Remove if statement. __handle_zypper_updated_or_reboot_exit_codes() will be called always irrespective of error code
Addendum to #135.
The fix for #135 did not work because there was one more location that was setting the package manager run to be repeated even on dry runs. This PR fixes it by removing that location and only having one location that handles any reboot/repeat exit codes (and now a message in the output as well)