Skip to content

Conversation

feng-j678
Copy link
Contributor

[x] the extra comma at the end of tombstone_name is causing json deserialization error, this extra comma is creating a tuple/list when tombstone is output in status file, so during json deserialization step of the data it will be unable to deserialize the tuple since it's supposed to be a string
[x] prior code change:
image
[x] post code change:
image
[x]
image

@feng-j678 feng-j678 changed the title Remove comma the end of tombstone_name to fix json deserialization Remove a comma the end of the tombstone_name to fix json deserialization Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (6cf2812) to head (9d02fbf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          96       96           
  Lines       16105    16105           
=======================================
  Hits        14859    14859           
  Misses       1246     1246           
Flag Coverage Δ
python27 92.26% <100.00%> (ø)
python39 92.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feng-j678 feng-j678 merged commit e989b35 into master Jan 15, 2025
7 checks passed
@feng-j678 feng-j678 deleted the fix/tombstone_json_parse_eror branch January 15, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants