Skip to content

Remove a comma the end of the tombstone_name to fix json deserialization #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Remove a comma the end of the tombstone_name to fix json deserialization #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/src/service_interfaces/StatusHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@ def __create_assessment_tombstone(self, classification_name, patches_count_by_cl
Patch Name: 20 additional updates of classification <classification_name> reported.
Classification: [Critical, Security, Other]
"""
tombstone_name = str(patches_count_by_classification) + ' additional updates of classification ' + classification_name + ' reported',
tombstone_name = str(patches_count_by_classification) + ' additional updates of classification ' + classification_name + ' reported'
return {
'patchId': 'Truncated_patch_list_id',
'name': tombstone_name,
Expand Down
2 changes: 1 addition & 1 deletion src/core/tests/Test_StatusHandlerTruncation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ def __assert_assessment_tombstone_record(self, truncated_substatus_file_data, to
truncated_substatus_msg = self.__get_message_json_from_substatus(truncated_substatus_file_data)
self.assertEqual(truncated_substatus_msg['patches'][-1]['patchId'], "Truncated_patch_list_id")
self.assertEqual(truncated_substatus_msg['patches'][-1]['classifications'], ['Other'])
self.assertTrue("additional updates of classification" in truncated_substatus_msg['patches'][-1]['name'][0])
self.assertTrue("additional updates of classification" in truncated_substatus_msg['patches'][-1]['name'])

if tombstone_count >= 2:
self.assertEqual(truncated_substatus_msg['patches'][-2]['patchId'], "Truncated_patch_list_id")
Expand Down
Loading