Fix the version comparator bug for ubuntu pro client version extraction #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feng-j678
requested review from
kjohn-msft,
rane-rajasi and
najams
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 92.43% 92.43% -0.01%
==========================================
Files 97 97
Lines 16226 16237 +11
==========================================
+ Hits 14999 15008 +9
- Misses 1227 1229 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kjohn-msft
reviewed
Mar 11, 2025
kjohn-msft
reviewed
Mar 11, 2025
kjohn-msft
reviewed
Mar 11, 2025
kjohn-msft
reviewed
Mar 11, 2025
kjohn-msft
reviewed
Mar 11, 2025
kjohn-msft
reviewed
Mar 13, 2025
…into hotfix/version_comparator_ubuntupro_version pull master changes.
rane-rajasi
reviewed
Mar 13, 2025
rane-rajasi
reviewed
Mar 13, 2025
kjohn-msft
approved these changes
Mar 14, 2025
michellemcdaniel
approved these changes
Mar 14, 2025
Merged
rane-rajasi
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] address the bug introduced in https://github.com/Azure/LinuxPatchExtension/pull/280/files
[x] address bug in ubuntu pro client vm where version comparator lib unable to extract the os version, so pro client query is not working:
core test
handler test
post code change:
