[OE PR Comments] Version Comparator Comments as Code on PR Branch #296
+128
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohn-msft
changed the title
feng-j678
reviewed
Mar 14, 2025
| "32.101.15~18", | ||
| "32.101~18.01", | ||
| "32.1~18.04.01", | ||
| "32~18.04.01"] |
There was a problem hiding this comment.
since we are not using this logic for os version comparison in handler, then we need to remove the os version comment
feng-j678
suggested changes
Mar 14, 2025
| Input: "/var/lib/waagent/Microsoft.CPlat.Core.LinuxPatchExtension-1.6.100" | ||
| Return: (1.6.100) | ||
| os version input: "34~18.04" |
There was a problem hiding this comment.
since we are not using this logic for os version comparison in handler, then we need to remove the os version comment
feng-j678
merged commit 3b411bf
into
hotfix/version_comparator_ubuntupro_version
1 check passed
Merged
kjohn-msft
added a commit
that referenced
this pull request
Mar 14, 2025
…on (#294) * fix the version comparator for ubuntu pro client version extraction * fix the version comparator logic * update extraction method for ubuntuproclient * add unit test for mock pro client version * use basepath() to extract last part of lpe path with version * use constant for linuxpatchextenstion * change MAX_OS_MAJOR_VERSION_SUPPORTED to 20 * Version Comparator Comments as Code on PR Branch (#296) * remove linuxpatchextension constants and os version comments in handler --------- Co-authored-by: Koshy John <kjohn@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge into hotfix/version_comparator.. as a reflection of comments I have.
Use hotfix/version_comparator after that as final review with 2 reviewers, etc.