Skip to content

Conversation

kjohn-msft
Copy link
Collaborator

@kjohn-msft kjohn-msft commented Apr 9, 2025

There was base code introduced 5+ years back to eventually switch over test execution to an emulated model. While the path would have been possible, competing priorities have not let it finish. Removing all the code around it for now.

The original goal was to be able to record the execution of the code on any real machine. That could be played back on any dev machine to allow time travel debugging. And could also allow for faster test code generation.

Some entities in Envlayer may be cleaned up further but leaving them as-is for now.

@kjohn-msft kjohn-msft added the engg. hygiene Engineering hygiene related label Apr 9, 2025
@kjohn-msft kjohn-msft self-assigned this Apr 9, 2025
@Copilot Copilot AI review requested due to automatic review settings April 9, 2025 22:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/core/src/bootstrap/EnvLayer.py:362

  • [nitpick] The 'time' method in DateTime does not use 'self' and is used similarly to the other static methods. Consider marking it with @staticmethod and removing the 'self' parameter for consistency.
def time(self):

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 95.87629% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.53%. Comparing base (97667b9) to head (ab61395).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/core/src/bootstrap/EnvLayer.py 94.36% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   93.15%   93.53%   +0.38%     
==========================================
  Files         103      103              
  Lines       17608    17458     -150     
==========================================
- Hits        16402    16330      -72     
+ Misses       1206     1128      -78     
Flag Coverage Δ
python27 93.53% <95.87%> (+0.38%) ⬆️
python312 93.53% <95.87%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kjohn-msft kjohn-msft added the OE PR is considered near complete due to OE sign-off. label Apr 11, 2025
@kjohn-msft kjohn-msft requested a review from feng-j678 April 14, 2025 17:03
Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline

@kjohn-msft kjohn-msft merged commit d18a9ce into master May 2, 2025
8 checks passed
@kjohn-msft kjohn-msft deleted the kjohn-trim branch May 2, 2025 23:06
@feng-j678 feng-j678 mentioned this pull request May 9, 2025
feng-j678 added a commit that referenced this pull request May 9, 2025
this release includes:
[x] [Bugfix: Restore patch mode config on Image Default
#301](#301)
[x] [Clean-up: Envlayer dead-code clean-up for Environment Recorder and
Emulator #304](#304)
[x] [Bugfix: Reboot Manager behavior - multiple bugfixes & error rate
reduction #310](#310)
[x] [Bugfix: Fix sudo check logs and wordings
#315](#315)
[x] [Bugfix: Mitigation for environments with Python Unbuffered I/O
#320](#320)
@feng-j678 feng-j678 mentioned this pull request May 12, 2025
kjohn-msft pushed a commit that referenced this pull request May 12, 2025
this release includes:
[x] Bugfix: Restore patch mode config on Image Default
(#301)
[x] Clean-up: Envlayer dead-code clean-up for Environment Recorder and
Emulator ( #304)
[x] Bugfix: Reboot Manager behavior - multiple bugfixes & error rate
reduction (#310)
[x] Bugfix: Fix sudo check logs and wordings
(#315)
[x] Bugfix: Mitigation for environments with Python Unbuffered I/O 
 (#320)
[x] Bugfix: Correct reboot management
parameters(#322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engg. hygiene Engineering hygiene related OE PR is considered near complete due to OE sign-off.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants