-
Notifications
You must be signed in to change notification settings - Fork 11
Clean-up: Envlayer dead-code clean-up for Environment Recorder and Emulator #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/core/src/bootstrap/EnvLayer.py:362
- [nitpick] The 'time' method in DateTime does not use 'self' and is used similarly to the other static methods. Consider marking it with @staticmethod and removing the 'self' parameter for consistency.
def time(self):
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 93.15% 93.53% +0.38%
==========================================
Files 103 103
Lines 17608 17458 -150
==========================================
- Hits 16402 16330 -72
+ Misses 1206 1128 -78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments inline
this release includes: [x] [Bugfix: Restore patch mode config on Image Default #301](#301) [x] [Clean-up: Envlayer dead-code clean-up for Environment Recorder and Emulator #304](#304) [x] [Bugfix: Reboot Manager behavior - multiple bugfixes & error rate reduction #310](#310) [x] [Bugfix: Fix sudo check logs and wordings #315](#315) [x] [Bugfix: Mitigation for environments with Python Unbuffered I/O #320](#320)
this release includes: [x] Bugfix: Restore patch mode config on Image Default (#301) [x] Clean-up: Envlayer dead-code clean-up for Environment Recorder and Emulator ( #304) [x] Bugfix: Reboot Manager behavior - multiple bugfixes & error rate reduction (#310) [x] Bugfix: Fix sudo check logs and wordings (#315) [x] Bugfix: Mitigation for environments with Python Unbuffered I/O (#320) [x] Bugfix: Correct reboot management parameters(#322)
There was base code introduced 5+ years back to eventually switch over test execution to an emulated model. While the path would have been possible, competing priorities have not let it finish. Removing all the code around it for now.
The original goal was to be able to record the execution of the code on any real machine. That could be played back on any dev machine to allow time travel debugging. And could also allow for faster test code generation.
Some entities in Envlayer may be cleaned up further but leaving them as-is for now.