Bugfix: Correct reboot management parameters #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into BugFix/correct_reboot_mg_parm pull master changes
feng-j678
requested review from
kjohn-msft,
rane-rajasi and
najams
as code owners
There was a problem hiding this comment.
Pull Request Overview
The purpose of this PR is to fix the parameter passing for the reboot management functions that were causing test failures.
- Updated keyword parameters for the __reboot_wait_pulse call
- Corrected the parameter name from maintenance_window_allowable_limit_remaining_in_minutes to maintenance_window_allowable_limit_remaining
Comments suppressed due to low confidence (1)
src/core/src/core_logic/RebootManager.py:145
- Ensure that the __reboot_wait_pulse method's signature is updated to accept the new keyword parameter names, particularly the change from 'maintenance_window_allowable_limit_remaining_in_minutes' to 'maintenance_window_allowable_limit_remaining'.
self.__reboot_wait_pulse(elapsed_time_in_minutes = int(elapsed_time_in_minutes), max_allowable_time_to_reboot_in_minutes = int(max_allowable_time_to_reboot_in_minutes), maintenance_window_allowable_limit_remaining = int(maintenance_window_available_time_in_minutes - elapsed_time_in_minutes))
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 103 103
Lines 17925 17925
=======================================
Hits 16810 16810
Misses 1115 1115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kjohn-msft
approved these changes
May 12, 2025
kjohn-msft
changed the title
michellemcdaniel
approved these changes
May 12, 2025
Merged
kjohn-msft
pushed a commit
that referenced
this pull request
May 12, 2025
this release includes: [x] Bugfix: Restore patch mode config on Image Default (#301) [x] Clean-up: Envlayer dead-code clean-up for Environment Recorder and Emulator ( #304) [x] Bugfix: Reboot Manager behavior - multiple bugfixes & error rate reduction (#310) [x] Bugfix: Fix sudo check logs and wordings (#315) [x] Bugfix: Mitigation for environments with Python Unbuffered I/O (#320) [x] Bugfix: Correct reboot management parameters(#322)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] explicit set the parameters
[x] correct the type error: