Skip to content

Conversation

rane-rajasi
Copy link
Contributor

This is a simple renaming of TdnfPackageManager to AzL3PackageManager. Will be followed up by separating generic TdnfPackageManager implementations from Azure Linux 3 specific ones: #331

@rane-rajasi rane-rajasi requested review from a team, najams, michellemcdaniel, kjohn-msft, nikhim-um and Copilot and removed request for a team, najams, michellemcdaniel and nikhim-um September 15, 2025 16:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the TdnfPackageManager class to AzL3TdnfPackageManager to better reflect its Azure Linux 3 specific implementation. This refactoring prepares for future separation of generic TDNF functionality from Azure Linux 3 specific implementations.

  • Renamed the main class from TdnfPackageManager to AzL3TdnfPackageManager
  • Updated all import statements and references to use the new class name
  • Simplified the internal structure by removing nested class and moving constants to the main class level

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/core/src/package_managers/AzL3TdnfPackageManager.py Main class renamed and internal structure simplified by removing nested AzL3TdnfPackageManager class
src/core/src/bootstrap/ConfigurationFactory.py Updated import statement and class references to use new AzL3TdnfPackageManager name
src/core/tests/Test_AzL3TdnfPackageManager.py Updated test class name to match the renamed package manager class

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.83%. Comparing base (38b3f22) to head (87b572b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   93.83%   93.83%   -0.01%     
==========================================
  Files         103      103              
  Lines       18132    18129       -3     
==========================================
- Hits        17014    17011       -3     
  Misses       1118     1118              
Flag Coverage Δ
python27 93.82% <100.00%> (-0.01%) ⬇️
python312 93.83% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rane-rajasi rane-rajasi merged commit 407f78c into master Sep 15, 2025
8 checks passed
@rane-rajasi rane-rajasi deleted the rarane/azlinux/TdnfPkgMgr_refactor branch September 15, 2025 17:46
rane-rajasi added a commit that referenced this pull request Oct 2, 2025
Release includes:

- [AzL3Tdnf] Refactoring TDNF Package Manager separating Azure Linux
specializations in it's own implementation
[331](#331)
- [AzL3Tdnf] Renaming TdnfPackageManager to AzL3PackageManager
[332](#332)
- Feature: Azure Linux 3.0: Enhanced Support
[318](#318)
- Engg. hygiene: Explicit Codecov workflow permissions
[327](#327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants