Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: update containermonitoring addon for december release #2481

Merged
merged 11 commits into from
Jan 9, 2020
Merged

feat: update containermonitoring addon for december release #2481

merged 11 commits into from
Jan 9, 2020

Conversation

rashmichandrashekar
Copy link
Contributor

December release changes for Containermonitoring addon -
feat: High scale support
feat: 1.16 support
Complete set of changes here - https://github.com/microsoft/Docker-Provider/blob/ci_feature_prod/README.md

@rashmichandrashekar
Rashmi/ciprod12042019 (#3)
a3451d3 
improvement: Update Containermonitoring addon for december release (#1)
@rashmichandrashekar rashmichandrashekar changed the title Rashmi/ciprod12042019 (#3) improvement: Update Containermonitoring addon for december release Dec 18, 2019
@rashmichandrashekar
Copy link
Contributor Author

rashmichandrashekar commented Dec 18, 2019 •
edited
Loading

/assign @ganga1980

@rashmichandrashekar
Copy link
Contributor Author

/assign @devigned

@devigned
Copy link
Member

/approve

@devigned
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@devigned
Copy link
Member

Just a heads up the commit message doesn't follow semantic pull request rules. Please update it when you get a chance.

@codecov
Copy link

codecov bot commented Dec 19, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6703347). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2481   +/-   ##
=========================================
  Coverage          ?   72.12%           
=========================================
  Files             ?      130           
  Lines             ?    24468           
  Branches          ?        0           
=========================================
  Hits              ?    17647           
  Misses            ?     5799           
  Partials          ?     1022

@rashmichandrashekar
Copy link
Contributor Author

Just a heads up the commit message doesn't follow semantic pull request rules. Please update it when you get a chance.

I updated it after the PR was created. The rule suggested I add it in the title, and i did add a suggested prefix "improvement". The rule check doesnt seem to be picking up this change.. could you pls run the semantic PR check again?

@devigned devigned closed this Dec 19, 2019
@devigned devigned reopened this Dec 19, 2019
@devigned devigned changed the title improvement: Update Containermonitoring addon for december release feat: update containermonitoring addon for december release Dec 19, 2019
@devigned
Copy link
Member

@rashmichandrashekar the problem is that "improvement" is not one of accepted works (I think).

@devigned
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ganga1980
ganga1980 previously approved these changes Dec 19, 2019
View reviewed changes
@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackfrancis
Copy link
Member

@rashmichandrashekar we are currently only testing the container-monitoring addon on k8s v1.13-1.15. Is that correct? Or do you expect that this addon works on 1.16 and 1.17 also? (in which case we should add test coverage for those versions)

@jackfrancis
Copy link
Member

Run make generate and commit generated code to address unit test failure.

@rashmichandrashekar
Copy link
Contributor Author

@rashmichandrashekar we are currently only testing the container-monitoring addon on k8s v1.13-1.15. Is that correct? Or do you expect that this addon works on 1.16 and 1.17 also? (in which case we should add test coverage for those versions)

@jackfrancis - Are you taking about the vesions here -
aks-engine/test/e2e/test_cluster_configs/container_monitoring.json

@rashmichandrashekar
Fix: Updating generated file to fix unit tests (#6)
9a2da05 
fix: Updating generated file to fix unit tests
@rashmichandrashekar
Adding test coverage for 1.16 and 1.17 (#7)
30f980b 
Adding test coverage for 1.16 and 1.17
@rashmichandrashekar @jackfrancis
@marosset @rjaini @reachjainrahul @mboersma @jadarsie @PatrickLang @wenwu449 @jaer-tsun @aramase
Merging changes for omsagent latest release - ciprod01072020 after sy…
6703347 
…ncing from remote master(#8)

* chore: use go template comments for generate proxy certs script (#2336)

* fix: fix ARM dependency issues with vm user-specified extensions on node pools (#2398)

* fix: fix ARM dependency issues if many extensions are specified for a node profile

* fix scale up case for windows vhd case. (#2483)

* refactor: make cilium addon user-configurable (#2480)

* refactor: make cilium addon user-configurable

* chore: clarify that cilium doesn't work w/ 1.16 and above, add validation

* test: addons UT

* test: go template UT

* ci: use Standard_D8_v3 for cilium test, only run NetworkPolicy tests

* fix: error message language

* chore: remove debug fmt.Println

* ci: revert back to Standard_D2_v3

* chore: upgrade cni-plugins to v0.7.6 (#2484)

* fix: hard-coding hyper-v generation when using VHD URls as a quick unblock (#2487)

* feat: Configuring docker log rotation for Windows nodes (#2478)

* feat: Antrea plugin support in AKS Engine (#2407)

* Antrea plugin support in AKS Engine

* chore: clean up

* chore: use ContainerImage

* chore: generated code

* refactor: Updating antrea yaml to 0.2.0

Co-authored-by: Jack Francis <jackfrancis@gmail.com>

* chore: lint (#2493)

* test: revert change to default kubernetes.json api model example (#2494)

* chore: update cloud-provider-azure components to v0.4.0 (#2473)

* chore: update cloud-provider-azure components to v0.4.0

See https://github.com/kubernetes-sigs/cloud-provider-azure/releases/tag/v0.4.0

* refactor: strip MCR constant to base hostname of URL

* fix: fetch Azure cloud-manager images from /oss/kubernetes/

* refactor: make audit-policy and azure-cloud-provider addons user-configurable (#2496)

* chore: pre-pull k8s v1.15.7-azs (#2490)

* fix: Fix some path handling in collect-windows-logs script (#2488)

* docs: remove mentions of old orchestrators (#2501)

* chore: Targeting dec patches for windows VHD (#2505)

* refactor: move StorageClass into azure-cloud-provider addon (#2497)

* add "Standard_DS3_v2" to "AcceleratedNetworking" supported list (#2509)

* ci: collect logs during E2E runs (#2520)

* refactor: user-configurable flannel and scheduled maintenance addons (#2517)

* chore: update Azure NPM to v1.0.31 (#2521)

* feat: add support for Kubernetes 1.18.0-alpha.1 (#2503)

* feat: add support for Kubernetes 1.18.0-alpha.1

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md#changelog-since-v1170

* test: add 1.18 to Jenkinsfile

* ci: disable kms for 1.18

* chore: move flannel 1.18 spec to containeraddons

* chore: generated code

* fix: use new cloudprovider implementation for 1.18

Co-authored-by: Jack Francis <jackfrancis@gmail.com>

* test: don't test non-working >= 1.16 flannel + docker (#2524)

* fix: apply new master node labels for k8s v1.18+ compatibility (#2467)

* fix: apply new master node labels for k8s v1.18+ compatibility

* test: check master labels in the future for back-compat

* feat: cleaning up old kubelet/kubeproxy logs for Windows nodes (#2504)

* feat: cleaning up old kubelet/kubeproxy logs for Windows nodes

* Fixing path to look for logs

* generated files

* refactor: standardize to "addons", deprecate "containeraddons" (#2525)

* fix: configure addons before setting kubelet config (#2513)

* chore: update addon-resizer (#2527)

See https://github.com/kubernetes/autoscaler/releases/tag/addon-resizer-1.8.7

* fix: aci-connector region is ignored (#2535)

* test: use LOCATION env var for api model in E2E tests (#2542)

* fix: promote system addons to system-cluster-critical (#2533)

* test: use northeurope for byok testing (#2536)

* Changes for omsagent-version-ciprod01072020

* Committing generated file

Co-authored-by: Jack Francis <jackfrancis@gmail.com>
Co-authored-by: Mark Rossetti <marosset@microsoft.com>
Co-authored-by: Rohit <rjaini@microsoft.com>
Co-authored-by: Rahul Jain <58573065+reachjainrahul@users.noreply.github.com>
Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com>
Co-authored-by: Javier Darsie <44655727+jadarsie@users.noreply.github.com>
Co-authored-by: Patrick Lang <PatrickLang@users.noreply.github.com>
Co-authored-by: Wenjun Wu <wenjun.wu@live.com>
Co-authored-by: Jaeryn <13284103+jaer-tsun@users.noreply.github.com>
Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
merging from remote
d1219c0
deleting github merge auto-generated files
bd8d363
Adding back 1.17 omsagent yaml changes
ab15b86
@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jackfrancis
jackfrancis approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jan 9, 2020
@acs-bot acs-bot merged commit ffc3e95 into Azure:master Jan 9, 2020
@acs-bot
Copy link

acs-bot commented Jan 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned, jackfrancis, rashmichandrashekar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [devigned,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@ganga1980 ganga1980 ganga1980 left review comments

Assignees

@devigned devigned

@jackfrancis jackfrancis

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rashmichandrashekar @devigned @jackfrancis @acs-bot @ganga1980