Skip to content

Conversation

kristapratico
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@kristapratico kristapratico marked this pull request as ready for review May 14, 2025 21:27
@Copilot Copilot AI review requested due to automatic review settings May 14, 2025 21:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated azure-ai-generative mapping from the type completeness script, ensuring the script no longer references a removed library.

  • Removed the azure-ai-generative entry from the main type-score mapping
Comments suppressed due to low confidence (2)

scripts/repo_type_completeness/generate_main_typescores.py:83

  • Removing the azure-ai-generative mapping could break score generation for that package if it’s still referenced elsewhere. Verify that no other part of the script or related tests assume its presence.
"azure-ai-generative": ["azure-ai-resources"],

scripts/repo_type_completeness/generate_main_typescores.py:83

  • Add or update tests to confirm the script handles the absence of the azure-ai-generative package gracefully and no longer computes scores for it.
"azure-ai-generative": ["azure-ai-resources"],

@kristapratico kristapratico merged commit 21d82c6 into main May 14, 2025
19 checks passed
@kristapratico kristapratico deleted the fix-typing-script branch May 14, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants