Skip to content

Conversation

v-dharmarajv
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Aug 28, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-communication-callautomation

@v-dharmarajv v-dharmarajv marked this pull request as ready for review August 29, 2025 17:56
@Copilot Copilot AI review requested due to automatic review settings August 29, 2025 17:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses MyPy type checking issues in the Azure Communication Call Automation SDK. The changes focus on resolving type annotation errors by adding explicit type ignores, improving null safety, and adding proper type casting.

Key Changes

  • Added type ignore comments for credential and argument type mismatches
  • Improved null safety with fallback values for optional parameters
  • Added explicit type casting to resolve type checker warnings

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
samples/create_call_sample.py Added fallback value for connection string environment variable
mypy.ini Added MyPy configuration file with relaxed settings
aio/_content_downloader_async.py Fixed hostname null safety and client attribute access
aio/_call_connection_client_async.py Added type ignores and improved parameter handling
aio/_call_automation_client_async.py Fixed type casting and async iterator implementation
_utils.py Added explicit type casting for identifier serialization
_shared/models.py Added type ignores for identifier return types
_models.py Improved null safety in model generation methods
_generated/models/_models.py Added datetime import
_content_downloader.py Fixed hostname null safety
_call_connection_client.py Added type ignores and improved casting
_call_automation_client.py Fixed type casting and parameter handling
apiview-properties.json Added new API view configuration file

@annatisch annatisch merged commit 794d4a0 into main Sep 9, 2025
19 checks passed
@annatisch annatisch deleted the users/v-dharmarajv/fixingMypyIssues branch September 9, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants