-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fixing mypy issues #42756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing mypy issues #42756
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request addresses MyPy type checking issues in the Azure Communication Call Automation SDK. The changes focus on resolving type annotation errors by adding explicit type ignores, improving null safety, and adding proper type casting.
Key Changes
- Added type ignore comments for credential and argument type mismatches
- Improved null safety with fallback values for optional parameters
- Added explicit type casting to resolve type checker warnings
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
samples/create_call_sample.py | Added fallback value for connection string environment variable |
mypy.ini | Added MyPy configuration file with relaxed settings |
aio/_content_downloader_async.py | Fixed hostname null safety and client attribute access |
aio/_call_connection_client_async.py | Added type ignores and improved parameter handling |
aio/_call_automation_client_async.py | Fixed type casting and async iterator implementation |
_utils.py | Added explicit type casting for identifier serialization |
_shared/models.py | Added type ignores for identifier return types |
_models.py | Improved null safety in model generation methods |
_generated/models/_models.py | Added datetime import |
_content_downloader.py | Fixed hostname null safety |
_call_connection_client.py | Added type ignores and improved casting |
_call_automation_client.py | Fixed type casting and parameter handling |
apiview-properties.json | Added new API view configuration file |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines