Skip to content

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented Oct 24, 2016

Ports KeyVault convenience layer logic and tests from the NodeSDK.

Note that one change was made to the autorest generated client to remove id from the call to set_certificate_contacts.

@tjprescott
Copy link
Member Author

cc/ @lmazuel @pomortaz

@lmazuel lmazuel added the ARM label Dec 13, 2016
@codecov-io
Copy link

Current coverage is 58.01% (diff: 93.36%)

Merging #828 into master will increase coverage by 1.39%

@@             master       #828   diff @@
==========================================
  Files          1755       1822     +67   
  Lines         48684      50448   +1764   
  Methods           0          0           
  Messages          0          0           
  Branches          0          0           
==========================================
+ Hits          27564      29266   +1702   
- Misses        21120      21182     +62   
  Partials          0          0           

Powered by Codecov. Last update 2b7a047...a852780

@lmazuel lmazuel merged commit d62963c into master Dec 29, 2016
@lmazuel lmazuel deleted the keyvault_data branch January 31, 2017 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants