Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSTest.TestAdapter from 2.1.2 to 2.2.1 #1673

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 2, 2021

Bumps MSTest.TestAdapter from 2.1.2 to 2.2.1.

Release notes

Sourced from MSTest.TestAdapter's releases.

v2.2.1

See release notes here.

v2.2.0-preview-20210115-03

See release notes here.

v2.2.0-preview-20201126-03

See release notes here.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Mar 2, 2021
@anthony-c-martin anthony-c-martin enabled auto-merge (squash) March 2, 2021 05:57
@dependabot dependabot bot force-pushed the dependabot/nuget/MSTest.TestAdapter-2.2.1 branch from 4d7065c to 762fd08 Compare March 2, 2021 07:14
@anthony-c-martin
Copy link
Member

This is odd. I haven't had much time to dig into it, but seems like the format of the TestContext information has perhaps changed, as rather than passing a simple string, we're turning an arbitrary C# object into a string to format the output path:

'D:\a\bicep\bicep\src\Bicep.LangServer.IntegrationTests\TestResults\Deploy_runneradmin 2021-03-02 07_19_26\In\fv-az68-240\CompletionRequestShouldProduceExpectedCompletions(Bicep.Core.Samples.DataSet,System.String,System.Collections.Generic.IList`1<OmniSharp.Extensions.LanguageServer.Protocol.Models.Position>)\InvalidCycles_CRLF_empty'

This only causes CI failures on Windows, but this may be because Linux & OSX are more permissive w.r.t valid file/dir characters.

@majastrz
Copy link
Member

majastrz commented Mar 5, 2021

The behavior looks like a bug. I opened microsoft/testfx#793. Let's hold off on this change for now as I also saw strange behavior in VS with very simple tests after the upgrade. (Doesn't repro in the Bicep solution, but had issues with a basic test project.)

@anthony-c-martin
Copy link
Member

@dependabot rebase

Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1.
- [Release notes](https://github.com/microsoft/testfx/releases)
- [Commits](microsoft/testfx@v2.1.2...v2.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/MSTest.TestAdapter-2.2.1 branch from 762fd08 to 51ff868 Compare March 12, 2021 00:34
@anthony-c-martin anthony-c-martin merged commit 25bb943 into main Mar 12, 2021
@anthony-c-martin anthony-c-martin deleted the dependabot/nuget/MSTest.TestAdapter-2.2.1 branch March 12, 2021 00:54
majastrz added a commit that referenced this pull request Mar 12, 2021
majastrz added a commit that referenced this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants