-
Notifications
You must be signed in to change notification settings - Fork 279
Closed
Description
What happened?
A bug happened!
When default sp param value is defined in dab-config.json, and then a guid is provided, DAB/HC does not resolve the value to a UUID. here are the at fault code sections which need to be addressed:
data-api-builder/src/Service.GraphQLBuilder/GraphQLUtils.cs
Lines 243 to 258 in a102e44
Tuple<string, IValueNode> valueNode = paramValueType switch | |
{ | |
BYTE_TYPE => new(BYTE_TYPE, new IntValueNode(byte.Parse(defaultValueFromConfig))), | |
SHORT_TYPE => new(SHORT_TYPE, new IntValueNode(short.Parse(defaultValueFromConfig))), | |
INT_TYPE => new(INT_TYPE, new IntValueNode(int.Parse(defaultValueFromConfig))), | |
LONG_TYPE => new(LONG_TYPE, new IntValueNode(long.Parse(defaultValueFromConfig))), | |
STRING_TYPE => new(STRING_TYPE, new StringValueNode(defaultValueFromConfig)), | |
BOOLEAN_TYPE => new(BOOLEAN_TYPE, new BooleanValueNode(bool.Parse(defaultValueFromConfig))), | |
SINGLE_TYPE => new(SINGLE_TYPE, new SingleType().ParseValue(float.Parse(defaultValueFromConfig))), | |
FLOAT_TYPE => new(FLOAT_TYPE, new FloatValueNode(double.Parse(defaultValueFromConfig))), | |
DECIMAL_TYPE => new(DECIMAL_TYPE, new FloatValueNode(decimal.Parse(defaultValueFromConfig))), | |
DATETIME_TYPE => new(DATETIME_TYPE, new DateTimeType().ParseResult( | |
DateTime.Parse(defaultValueFromConfig, DateTimeFormatInfo.InvariantInfo, DateTimeStyles.AssumeUniversal))), | |
BYTEARRAY_TYPE => new(BYTEARRAY_TYPE, new ByteArrayType().ParseValue(Convert.FromBase64String(defaultValueFromConfig))), | |
LOCALTIME_TYPE => new(LOCALTIME_TYPE, new LocalTimeType().ParseResult(LocalTimePattern.ExtendedIso.Parse(defaultValueFromConfig).Value)), | |
_ => throw new NotSupportedException(message: $"The {defaultValueFromConfig} parameter's value type [{paramValueType}] is not supported.") |
data-api-builder/src/Service.GraphQLBuilder/GraphQLStoredProcedureBuilder.cs
Lines 51 to 56 in a102e44
IValueNode? defaultValueNode = null; | |
if (entity.Source.Parameters is not null && entity.Source.Parameters.TryGetValue(param, out object? value)) | |
{ | |
Tuple<string, IValueNode> defaultGraphQLValue = ConvertValueToGraphQLType(value.ToString()!, parameterDefinition: spdef.Parameters[param]); | |
defaultValueNode = defaultGraphQLValue.Item2; | |
} |
Version
main/latest
What database are you using?
Azure SQL
What hosting model are you using?
Local (including CLI)
Which API approach are you accessing DAB through?
GraphQL
Relevant log output
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working