Resolve uniqueidentifier database type from dab-config.json defined stored proc parameter default values.

[seantleonard]

Why make this change?

• Closes [Bug]: Parse sp parameter default value from runtime config when target type is UUID. #2027. DAB would not start up correctly when runtime config took the following form:

  "entities": {
    "SpUuidParam": {
      "source": {
        "object": "sp_uuid_param",
        "type": "stored-procedure",
        "parameters": {
          "param1": "f58b7b58-62c9-4b97-ab60-75de70793f66"
        }
      },
      "graphql": {
        "enabled": true,
        "operation": "Query",
        "type": {
          "singular": "SpUuidParam",
          "plural": "SpUuidParams"
        }
      },
      "rest": {
        "enabled": true
      },
      "permissions": [
        {
          "role": "anonymous",
          "actions": [ "*" ]
        },
        {
          "role": "authenticated",
          "actions": [ "*" ]
        }
      ]
    }

And stored proc in tsql

CREATE PROCEDURE [dbo].[sp_uuid_param] @param1 uniqueidentifier AS
      SELECT @param1 AS [ReturnPayload]

DAB was lacking the ability to handle the stored procedure having an input parameter with value type uniqueidentifier. When a default value was defined in the config, that value would fail conversion to the UUID type during GraphQL schema creation.

The call stack flows through:

                    if (entity.Source.Parameters is not null && entity.Source.Parameters.TryGetValue(param, out object? value))
                    {
                        Tuple<string, IValueNode> defaultGraphQLValue = ConvertValueToGraphQLType(value.ToString()!, parameterDefinition: spdef.Parameters[param]);
                        defaultValueNode = defaultGraphQLValue.Item2;
                    }

where ConvertValueToGraphQLType(...) would attempt to convert the config defined value to a GraphQL type based on the type inferred from the parameter's SystemType (System.Guid). The parameter object has the following properties when the parameter is passed to that function:

• SystemType -> System.Guid
• DbType -> Guid
• ConfigDefaultValue -> f58b7b58-62c9-4b97-ab60-75de70793f66
• HasConfigDefault -> true

ConvertValueToGraphQLType(...) did not have the conversion needed to create a UUID type.

What is this change?

• In the function called to process config defined default values for stored procedure parameters, ConvertValueToGraphQLType(...) add the conversion:

UUID_TYPE => new(UUID_TYPE, new UuidType().ParseValue(Guid.Parse(defaultValueFromConfig))),

• Moved ConvertValueToGraphQLType() from GraphQLUtils.cs to GraphQLStoredProcedureBuilder.cs to align with usage and purpose of function. Reduces size of MEGA UTIL class. Also adds comment for GraphQLUtils.BuiltInTypes hashset entry 'ID' to inform that it enables CosmosDB functionality as only cosmos tests failed when that entry was commented out.
• Reorganizes the ConvertValueToGraphQLType() order of types in switch statements to align with GraphQLUtils.BuiltInTypes hashset. That way it is easier to notice discrepancies in the two lists.

How was this tested?

• Integration Tests

Sample Request(s)

• Use the db schema and entity config provided above. Startup will succeed without conversion errors when attempting to create the GraphQL schema.

[Aniruddh25]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[severussundar]

Suggestion to include test cases with different UUID formats. Otherwise, looks good.

[Aniruddh25]

LGTM, thanks for the quick fix!

[seantleonard]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[aaronburtle]

Looks good!

[seantleonard]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).