Skip to content

Conversation

ayush3797
Copy link
Contributor

Why make this change?

Currently we perform recursive AuthZ and request validation even when multiple-create is not enabled, which is not required. This PR adds logic to perform recursive authz and request validation only when multiple-create is enabled.

How was this tested?

Existing tests provide the coverage.

@ayush3797
Copy link
Contributor Author

/azp run

@ayush3797 ayush3797 enabled auto-merge (squash) May 2, 2024 07:39
@ayush3797 ayush3797 added improvement Let's make this better Multiple mutations Fixes/enhancements related to nested mutations. labels May 2, 2024
@ayush3797 ayush3797 self-assigned this May 2, 2024
@ayush3797 ayush3797 added this to the 1.1rc milestone May 2, 2024
Copy link
Contributor

@abhishekkumams abhishekkumams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayush3797 ayush3797 merged commit db235d0 into main May 2, 2024
@ayush3797 ayush3797 deleted the dev/agarwalayush/doRecursiveauthZandReqValidationOnlyWhenMultipleCreateIsEnabled branch May 2, 2024 08:04
@ayush3797 ayush3797 added the bug Something isn't working label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Let's make this better Multiple mutations Fixes/enhancements related to nested mutations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants