Skip to content

Perform recursive authz and request validation only when multiple-create is enabled #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2024
Merged

Perform recursive authz and request validation only when multiple-create is enabled #2199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a676b35
Perform recursive authz and request validation only when multiple-cre…
ayush3797 May 2, 2024
7b78169
Merge branch 'main' into dev/agarwalayush/doRecursiveauthZandReqValid…
ayush3797 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Core/Resolvers/SqlMutationEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,12 @@ public SqlMutationEngine(
// If authorization fails, an exception will be thrown and request execution halts.
AuthorizeMutation(context, parameters, entityName, mutationOperation);

// Multiple create mutation request is validated to ensure that the request is valid semantically.
string inputArgumentName = IsPointMutation(context) ? MutationBuilder.ITEM_INPUT_ARGUMENT_NAME : MutationBuilder.ARRAY_INPUT_ARGUMENT_NAME;
if (parameters.TryGetValue(inputArgumentName, out object? param) && mutationOperation is EntityActionOperation.Create)
if (_runtimeConfigProvider.GetConfig().IsMultipleCreateOperationEnabled() &&
parameters.TryGetValue(inputArgumentName, out object? param) &&
mutationOperation is EntityActionOperation.Create)
{
// Multiple create mutation request is validated to ensure that the request is valid semantically.
IInputField schemaForArgument = context.Selection.Field.Arguments[inputArgumentName];
MultipleMutationEntityInputValidationContext multipleMutationEntityInputValidationContext = new(
entityName: entityName,
Expand Down Expand Up @@ -2034,7 +2036,7 @@ public void AuthorizeMutation(
{
string inputArgumentName = MutationBuilder.ITEM_INPUT_ARGUMENT_NAME;
string clientRole = AuthorizationResolver.GetRoleOfGraphQLRequest(context);
if (mutationOperation is EntityActionOperation.Create)
if (mutationOperation is EntityActionOperation.Create && _runtimeConfigProvider.GetConfig().IsMultipleCreateOperationEnabled())
{
if (!IsPointMutation(context))
{
Expand Down