Skip to content

Conversation

Ugonnaak1
Copy link
Contributor

@Ugonnaak1 Ugonnaak1 requested a review from a team as a code owner September 25, 2025 21:21
@rayluo rayluo requested a review from Copilot September 26, 2025 04:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR deprecates the ROPC (Resource Owner Password Credentials) API across the MSAL Python library by adding deprecation warnings and skipping related tests. The deprecation includes updating documentation, adding warning messages, and providing migration guidance.

  • Add deprecation warnings to ROPC-related methods in application.py and main.py
  • Skip all ROPC-related tests across multiple test files using @unittest.skip decorator
  • Update sample code to log deprecation information
  • Remove ROPC function from the interactive CLI menu

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
msal/application.py Add deprecation warning and updated docstring for acquire_token_by_username_password method
msal/main.py Add deprecation warning to ROPC function and remove it from CLI menu
sample/username_password_sample.py Add logging message indicating the flow is deprecated
tests/test_e2e.py Skip ROPC-related tests with deprecation message
tests/test_ccs.py Skip ROPC test method
tests/test_application.py Skip ROPC-related test methods
tests/test_account_source.py Skip ROPC test method
tests/broker-test.py Add unittest import and skip ROPC test function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Ugonnaak1 Ugonnaak1 requested a review from rayluo September 26, 2025 23:56
Co-authored-by: Bogdan Gavril <bogavril@microsoft.com>
Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort addressing all the comments!

@rayluo rayluo merged commit 562d72e into dev Sep 30, 2025
19 checks passed
@rayluo rayluo deleted the akaliugonna/deprecateROPCflow branch September 30, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants