Skip to content

Conversation

Azureyjt
Copy link
Owner

@Azureyjt Azureyjt commented Oct 8, 2019

Pull request title

  • Clearly and concisely describes what it does
  • Refer to the issue that it solves, if available

Pull request description

  • Describes the main changes that come with the pull request
  • Any relevant additional information is provided

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

perwramdemark and others added 8 commits October 3, 2019 21:50
* Upgrade maven plugins

* Upgrade maven plugins

Some general code cleanup was necessary due to upgrade of PMD and checkstyle.

Also needed to add Junit 4 as a dependency due to Mockito.timout issue found here:
mockito/mockito#152
…roservice (#958)

*  Fix for Issue##549

Catch ClientProtocolException and Update Error Logs

* Fix indentation, checkstyle errors
* Fix for issue #954
Add javax.annotation and java.xml.bind as external maven dependencies
Verified with jdk-11

* Move dependency versions to main pom.xml's dependencyManagement section
@Azureyjt Azureyjt merged commit 8e79755 into Azureyjt:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants