Update Mullions.json #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enarhi
reviewed
May 28, 2021
There was a problem hiding this comment.
@vgreen-BH looks like the last entry cam through without a name:
Could you also please rename the dataset to Mullions(Kawneer), and rename the JSON to match? Aside from that it looks good, if you can just update to fix those bits then I'll go ahead and rereview.
Fixed missing name on last mullion item. Renamed dataset and JSON to "Mullions(Kawneer)"
|
@vgreen-BH looks the 1600's have a units issues as they are substantially larger than the others (about 9' deep!). Can you update those with the right scaling please? |
Fixed size units for Kawneer 1600 Mullions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #89
Adds two new mullion systems (Kawneer 2500, Kawneer 1600) to the facade mullion database.