Skip to content

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #96

Simple upgrade of the contents of the Dataset, making use of the Versioning_Toolkit.

Can this please be reviewed and merged ASAP, as it slows down the use of all dataset, first time, and can give notes to components/general upgrader popups to scripts that do not use the dataset at all, see example below:

image

Test files

Please ensure that the dataset still loads as expected and still contains correct information. The content should be identical to before.

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added type:compliance Non-conforming to code guidelines priority:high High impact, high user value, driven by live project needs labels Sep 8, 2021
@IsakNaslundBh IsakNaslundBh self-assigned this Sep 8, 2021
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • dataset-compliance

@FraserGreenroyd FraserGreenroyd merged commit 87912a3 into master Sep 8, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Datasets-#96-UpgradeOldMEPDatasets branch September 8, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High impact, high user value, driven by live project needs type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset needing upgrading
2 participants