Skip to content

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #130

added a boolean "run" to BasePythonEnvironment, and added PreviousVersion and Input attributes.

Test files

place a BasePythonEnvironment component on the canvas and input a bool into run. Test that setting Run to true returns the Python environment.

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:user-experience Issues and changes relating to improving the overall User Experience (UX) of the tools label Dec 12, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Dec 12, 2023
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core, compliance

Copy link

bhombot-ci bot commented Dec 12, 2023

@Tom-Kingstone sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Dec 12, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Dec 12, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 13 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check documentation-compliance

Copy link

bhombot-ci bot commented Dec 12, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check documentation-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Dec 12, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core

Copy link

bhombot-ci bot commented Dec 13, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Dec 13, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 2 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 13, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Dec 13, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Dec 13, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Dec 13, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing all checks pass then this is good from code inspection, cheers @Tom-Kingstone

Copy link

bhombot-ci bot commented Dec 13, 2023

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Dec 13, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is installer.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19589955334

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19589955334

Copy link

bhombot-ci bot commented Dec 13, 2023

@FraserGreenroyd I have now provided a passing check on reference 19589955334 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 53d2762 into develop Dec 13, 2023
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#130-BasePythonEnvironmentRun branch December 13, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:user-experience Issues and changes relating to improving the overall User Experience (UX) of the tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a run bool as an input to BasePythonEnvironment
2 participants