Fixed missing build dependency for win32api #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Kingstone
added
type:bug
|
@BHoMBot check installer -force |
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
|
The check |
BHoMBot, please just run the installer check :P
|
@BHoMBot check installer |
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
Tom-Kingstone
removed
the
status:WIP
jamesramsden-bh
approved these changes
Jun 12, 2025
|
@BHoMBot check ready-to-merge |
|
@jamesramsden-bh to confirm, the following actions are now queued:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #176
Issue necessitated changing to pyproject.toml workflow for building python modules, so as much work as possible has been done to move to that.
Also fixed a problem adding kernels to jupyter if the entire kernels file was previously removed
Test files
needs to be installed with a downstream python toolkit, so no test file can be made at this level!
When the LadybugTools_Toolkit PR is created, will link here as that will contain a test file/procedure
Changelog
Additional comments
Changes to other toolkits that use python >= 3.10 will need to be made to be able to install virtual environments that should be dependent on this PR.