-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When parsing NVIDIA driver version, max minor version with 99. #3897
Conversation
I guess we thought these would never exceed 99, but they do. This is a temp workaround.
I fully intend to test this today, but I've just received an urgent call-out to deal with a hacking attack - it'll have to wait until I've got that under control. I would hope we could target this workround on the v7.16.8 (or whatever) bugfix already scheduled for this month. |
Thanks, @RichardHaselgrove |
Codecov Report
@@ Coverage Diff @@
## master #3897 +/- ##
=======================================
Coverage 16.51% 16.51%
=======================================
Files 134 134
Lines 13148 13148
Branches 1627 1627
=======================================
Hits 2172 2172
Misses 10844 10844
Partials 132 132 |
OK, I'm back. So far, I can only locate https://bintray.com/beta/#/boinc/boinc-ci/pull-requests/PR3896_2020-07-10_5b45f218?tab=files
|
You can test that one because it's the same as this one. |
Ta. I've downloaded it and started running it. So far,
It's crude and clunky, but I think it's better to get the science working again than to block a project while we think. I approve. |
Add to above:
|
This cleaner PR doesn't contain this commit with version change so everything should be fine. Thank for testing @RichardHaselgrove. I'm merging this then. |
I guess we thought these would never exceed 99, but they do.
This is a temp workaround.
Fixes #3893