Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When parsing NVIDIA driver version, max minor version with 99. #3897

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

AenBleidd
Copy link
Member

I guess we thought these would never exceed 99, but they do.
This is a temp workaround.

Fixes #3893

I guess we thought these would never exceed 99, but they do.
This is a temp workaround.
@RichardHaselgrove
Copy link
Contributor

I fully intend to test this today, but I've just received an urgent call-out to deal with a hacking attack - it'll have to wait until I've got that under control. I would hope we could target this workround on the v7.16.8 (or whatever) bugfix already scheduled for this month.

@AenBleidd
Copy link
Member Author

Thanks, @RichardHaselgrove

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #3897 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3897   +/-   ##
=======================================
  Coverage   16.51%   16.51%           
=======================================
  Files         134      134           
  Lines       13148    13148           
  Branches     1627     1627           
=======================================
  Hits         2172     2172           
  Misses      10844    10844           
  Partials      132      132           

@RichardHaselgrove
Copy link
Contributor

OK, I'm back. So far, I can only locate

https://bintray.com/beta/#/boinc/boinc-ci/pull-requests/PR3896_2020-07-10_5b45f218?tab=files

  • commit 5b45f21 is correct for @davidpanderson's version of this PR, but is there a cleaner link? I'll grab some lunch, then test fully.

@AenBleidd
Copy link
Member Author

You can test that one because it's the same as this one.
This is just a cleaner version of the PR but the particular state of branch is the same,
There's no artifacts on BinTray for this particular PR because I did it from my fork and Travis CI can't share BinTray secret key across forks, unfortunately

@RichardHaselgrove
Copy link
Contributor

Ta. I've downloaded it and started running it. So far,

(1) Fri 10 Jul 2020 14:48:16 BST |  | Starting BOINC client version 7.16.7 for x86_64-pc-linux-gnu
(2) Fri 10 Jul 2020 14:48:17 BST |  | CUDA: NVIDIA GPU 0: GeForce GTX 1660 SUPER (driver version 440.99, CUDA version 10.2, compute capability 7.5, 4096MB, 3974MB available, 5153 GFLOPS peak)
* Fri 10 Jul 2020 14:48:17 BST |  | OpenCL: NVIDIA GPU 0: GeForce GTX 1660 SUPER (driver version 440.100, device version OpenCL 1.2 CUDA, 5943MB, 3974MB available, 5153 GFLOPS peak)
Fri 10 Jul 2020 14:48:17 BST |  | Version change (7.17.0 -> 7.16.7)
Fri 10 Jul 2020 14:50:17 BST | Asteroids@home | work fetch resumed by user
Fri 10 Jul 2020 14:50:21 BST | Asteroids@home | Sending scheduler request: To fetch work.
Fri 10 Jul 2020 14:50:21 BST | Asteroids@home | Requesting new tasks for NVIDIA GPU
Fri 10 Jul 2020 14:50:21 BST | Asteroids@home | [sched_op] NVIDIA GPU work request: 180.00 seconds; 2.00 devices
(3) Fri 10 Jul 2020 14:50:23 BST | Asteroids@home | Scheduler request completed: got 2 new tasks
  1. Should not be a release version number for a test build - that will come from the non-atomic commits in When parsing NVIDIA driver version, max minor version with 99. #3896.
  2. Shows dotted version number for CUDA - better - but at this point we don't need to limit length (internal to client). The difference between the CUDA and OpenCL driver numbers will cause questions, which we will need to be ready to explain.
  3. But it achieves the object of the exercise - Asteroids works again.
  4. The host record on the project website (host 689103) shows the restricted driver number. This will again require explanation, but is inevitable bearing in mind the limitations of the current transfer format.

It's crude and clunky, but I think it's better to get the science working again than to block a project while we think. I approve.

@RichardHaselgrove
Copy link
Contributor

Add to above:

  1. No unwanted side-effects at other projects, except the truncated driver number (GPUGrid host 537311). Work has been reported complete, and replacement work issued, since the change.

@AenBleidd
Copy link
Member Author

Should not be a release version number for a test build - that will come from the non-atomic commits in #3896.

This cleaner PR doesn't contain this commit with version change so everything should be fine.

Thank for testing @RichardHaselgrove.

I'm merging this then.

@AenBleidd AenBleidd modified the milestones: Client/Manager 8.0, Client Release 7.16.8 Jul 10, 2020
@AenBleidd AenBleidd merged commit 86458f2 into BOINC:master Jul 10, 2020
@AenBleidd AenBleidd deleted the dpa_nvidia_vers_clean branch July 10, 2020 14:43
@AenBleidd AenBleidd modified the milestones: Client Release 7.18.0, Client Release 7.16.11 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUDA version number truncated
3 participants