-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ExternalData conditionally #3
Comments
Would be great to also address this issue 👍 Thanks |
JC, Where did you get that version of ExternalData.cmake. It does not match the version that is available in ITK. I want to try to keep all copies of ExternalData.cmake consistent across DTIPrep, BRAINSTools, ANTS, ITK, DTIAtlasBuilder, etc.... Is your version compatible with ITK? Hans |
This is the official version now bundled within CMake 2.8.11. On Wed, Mar 27, 2013 at 2:35 PM, hjmjohnson notifications@github.comwrote:
+1 919 869 8849 |
diff ~/src/Slicer/CMake/ExternalData.cmake ~/src/BRAINSTools/CMake/ExternalData.cmake Shows that BRAINSTools and Slicer have identical ExternalData.cmake files. |
Considering both projects now use the same version of the module, it is not required anymore to copy it. See the associated BRAINStools issue for more details: BRAINSia/BRAINSTools#3 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22904 3bd1e089-480b-0410-8dfb-8563597acbee
…ject See also BRAINSia/BRAINSTools#3 git-svn-id: http://svn.slicer.org/Slicer4/trunk@21792 3bd1e089-480b-0410-8dfb-8563597acbee
This is obviously a hack allowing to use ExternalData withing Slicer while building BRAINSTools. An issue has been reported upstream. See BRAINSia/BRAINSTools#3 git-svn-id: http://svn.slicer.org/Slicer4/trunk@21806 3bd1e089-480b-0410-8dfb-8563597acbee
Considering both projects now use the same version of the module, it is not required anymore to copy it. See the associated BRAINStools issue for more details: BRAINSia/BRAINSTools#3 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22904 3bd1e089-480b-0410-8dfb-8563597acbee
See 3b3b8c4#commitcomment-2784641
By applying the method reported in the comment, Slicer will be ensured to include its own version instead of the one bundled with BRAINS.
Waiting that all of our projects depends strictly on CMake 2.8.11, it allows the ExternalData.cmake within Slicer to be different ...
The text was updated successfully, but these errors were encountered: