Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ExternalData conditionally #3

Closed
jcfr opened this issue Mar 12, 2013 · 4 comments
Closed

Include ExternalData conditionally #3

jcfr opened this issue Mar 12, 2013 · 4 comments

Comments

@jcfr
Copy link
Contributor

jcfr commented Mar 12, 2013

See 3b3b8c4#commitcomment-2784641

By applying the method reported in the comment, Slicer will be ensured to include its own version instead of the one bundled with BRAINS.

Waiting that all of our projects depends strictly on CMake 2.8.11, it allows the ExternalData.cmake within Slicer to be different ...

@jcfr
Copy link
Contributor Author

jcfr commented Mar 13, 2013

Would be great to also address this issue 👍 Thanks

@hjmjohnson
Copy link
Member

JC,

Where did you get that version of ExternalData.cmake. It does not match the version that is available in ITK. I want to try to keep all copies of ExternalData.cmake consistent across DTIPrep, BRAINSTools, ANTS, ITK, DTIAtlasBuilder, etc....

Is your version compatible with ITK?

Hans

@jcfr
Copy link
Contributor Author

jcfr commented Mar 27, 2013

This is the official version now bundled within CMake 2.8.11.
See
http://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/ExternalData.cmake;h=187f408ffd5e43a9225d72e645832d61261987fa;hb=HEAD
Hth
Jc

On Wed, Mar 27, 2013 at 2:35 PM, hjmjohnson notifications@github.comwrote:

JC,

Where did you get that version of ExternalData.cmake. It does not match
the version that is available in ITK. I want to try to keep all copies of
ExternalData.cmake consistent across DTIPrep, BRAINSTools, ANTS, ITK,
DTIAtlasBuilder, etc....

Is your version compatible with ITK?

Hans


Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-15544021
.

+1 919 869 8849

@hjmjohnson
Copy link
Member

diff ~/src/Slicer/CMake/ExternalData.cmake ~/src/BRAINSTools/CMake/ExternalData.cmake

Shows that BRAINSTools and Slicer have identical ExternalData.cmake files.

jcfr added a commit to Slicer/SlicerGitSVNArchive that referenced this issue Feb 26, 2014
Considering both projects now use the same version of the module, it is
not required anymore to copy it.
See the associated BRAINStools issue for more details: BRAINSia/BRAINSTools#3

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22904 3bd1e089-480b-0410-8dfb-8563597acbee
pieper pushed a commit to pieper/SlicerGitSVNArchive that referenced this issue Apr 26, 2014
pieper pushed a commit to pieper/SlicerGitSVNArchive that referenced this issue Apr 26, 2014
This is obviously a hack allowing to use ExternalData withing Slicer while
building BRAINSTools. An issue has been reported upstream.
See BRAINSia/BRAINSTools#3

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21806 3bd1e089-480b-0410-8dfb-8563597acbee
finetjul pushed a commit to finetjul/Slicer that referenced this issue May 7, 2014
Considering both projects now use the same version of the module, it is
not required anymore to copy it.
See the associated BRAINStools issue for more details: BRAINSia/BRAINSTools#3

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22904 3bd1e089-480b-0410-8dfb-8563597acbee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants