Enables transparent backgrounds #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? :) |
|
Sorry, I was on vacation the last 2 weeks. Will go through this in the next few days :) |
| */ | ||
| public function getBackgroundColor() | ||
| { | ||
| if ($this->backgroundColor === null) { | ||
| $this->backgroundColor = new Color\Gray(100); |
There was a problem hiding this comment.
I'd argue that the default color should definitely be white. To make it possible to set transparency (by setting null as background color), I'd suggest to set the white value in the constructor.
|
Tested this pull request and it works well. 👍 Would be nice to see this functionality added to the package and a new version tagged. |
|
@DASPRiD Please can we get this PR merged and a new version tagged ? |
|
I've taken (semi-)transparent backgrounds into account in the 2.0 rewrite. I'm planning to have that one working pretty soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the option to render qrcodes with transparent backgrounds.
For the vector based renderers, this is achieved by simple not creating a white background by default any more.
For the png renderer, a transparent background layer is created when initialising the image; If no background color is set afterwards, the background remains transparent.
This breaks backwards compatibility because the the default (when not calling setBackgroundColor explicitly) are transparent backgrounds.
The only way to avoid that would be to introduce a new parameter to the constructor of the Renderer classes which toggles the behaviour, defaulting to non-transparent backgrounds. Semantically, I'd think a transparent background is a great starting point for an image and calling setBackgroundColor in case I want a color on top of that is ok :)
What do you think?
Thx for the great library :)