Skip to content

Fixes Issue #78 using PUT for set_activation_status() #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Fixes Issue #78 using PUT for set_activation_status() #80

merged 3 commits into from
Aug 17, 2021

Conversation

ooglek
Copy link
Contributor

@ooglek ooglek commented Aug 13, 2021

Fixes issue #78 using PUT for set_activation_status()

Consider a second set of tests that run against the dev server live! This could have been caught there. I know you may be rewriting the SDK so maybe that won't happen, but if this is sticking around for another few months, it may be worth the time.

@ajrice6713
Copy link
Contributor

Hey @ooglek - thanks for opening this PR, ill get it tested and merged today

as for integration testing - it is definitely something we are doing more of. We have this setup for the other bundled SDKs to run nightly in our api-docs repo, but unfortunately for the account and number management apis (dashboard.bandwidth.com) my team is blocked awaiting an OpenAPI spec

I hate to keep telling you "its coming eventually," because it seems like that is the response ive been giving for a year now - but we are working on this. We are preparing a survey right now to determine whether users of our APIs prefer a single bundled SDK with all services available in one package or individual SDKs for each service (numbers, account, voice, messaging, webrtc, etc) along with some other data points we want to measure,and from there we will decide on how we want to move forward with developing a more modern version of the SDKs that fit user needs better.

@ajrice6713
Copy link
Contributor

@ooglek we release bi-weekly on Tuesdays so this will go live on the 17th

@ooglek
Copy link
Contributor Author

ooglek commented Aug 14, 2021

It is always a challenge to bring a new platform or new dev process to bear in a changing environment.

In the end, it's all just an interface, and BW has great engineers like yourself to make sure it is as lightweight and as functional as possible. As long as the experience for the end user (EU) is great and the documentation is fully fleshed out and accurate, whatever path you go (segregated or unified, JSONAPI or OpenAPI or GraphQL, SDKs generated or hand-written) will be welcome.

Just give us enough time to find the dev hours to migrate!!! I've had APIs integrated that have worked the same way for 10+ years... still works, why change? ;-)

@ajrice6713 ajrice6713 merged commit cbd53ff into Bandwidth:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants