Skip to content

Fixes Issue #78 using PUT for set_activation_status() #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Fixes Issue #78 using PUT for set_activation_status() #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21607d7
Fixes Issue #78 using PUT for set_activation_status()
ooglek Aug 13, 2021
1943311
Update README.md
ajrice6713 Aug 13, 2021
9f4aac3
Update composer.json
ajrice6713 Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ PHP Client library for Bandwidth's Phone Number Dashboard (AKA: Dashboard, Iris)
| 3.2.0 | Update SipPeerTelephoneNumber to enable/disabe SMS |
| 3.3.0 | Added PortOutStatus, ActualFocDate, and SPID to the portout model |
| 3.3.1 | Updated the portins update method to clear the ActualFocDate field |
| 3.3.2 | Updated the portins set_activation_status method use a PUT method |

## Supported PHP Versions

Expand Down
3 changes: 1 addition & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Bandwidth's Iris SDK for PHP",
"keywords": ["iris","sdk","php"],
"homepage": "http://dev.bandwidth.com",
"reference": "v3.3.1",
"reference": "v3.3.2",
"license": "MIT",
"authors": [
],
Expand All @@ -25,4 +25,3 @@
]
}
}

2 changes: 1 addition & 1 deletion src/PortinsModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public function get_activation_status() {
public function set_activation_status($data) {
$obj = new \Iris\ActivationStatus($data);
$url = sprintf('%s/%s', $this->get_id(), 'activationStatus');
$res = parent::post($url, "ActivationStatus", $obj->to_array());
$res = parent::put($url, "ActivationStatus", $obj->to_array());
return new ActivationStatus($res['ActivationStatus']);
}

Expand Down