-
Notifications
You must be signed in to change notification settings - Fork 768
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
In bt_factory.cpp
, line 36:
registerNodeType<RetryNode>("RetryUntilSuccesful");
RetryUntilSuccesful
should be RetryUntilSuccessful
.
There are a few problems that will happen if we just fix this typo:
- since this is used to parse the xml files, changing this will make certain xml file unusable.
groot
exportsRetryUntilSuccesful
, so we need to fix groot too.
In order to solve this problem, I suggest:
- add a line
registerNodeType<RetryNode>("RetryUntilSuccessful");
so both versions are usable. - make a subclass of
RetryNode
(i.e.RetryNodeTypo
) and raise warning when used, so that we can depreciate afterwards. - fix the import/export of
groot
(I haven't read the code thoroughly, but a quick search indicates that we only need to change 1 line inbt_editor/resources/NodesStyle.json
, excluding the xml files.)
Fixing is not that hard, but the problem is that there will be some xml files that won't work with groot after the change.
@facontidavide do you have any good ideas?
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working