Fix Blackboard::set() for StringView #570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks. Do you have a simple unit test in mind that reproduce the error and fails before this change is applied? |
|
I could try to write one. Where should I write it? |
|
if you just show me a plain example, I can do it. |
galou
force-pushed
the
ge/fix/set_stringview
branch
3 times, most recently
from
9b6f74f to
7ffe080
Compare
The second call to `Blackboard::set()` with the same key was not working for `StringView` because `port_info.parseString(value)` returns an empty `Any`. `Any(std::string(value))` is used instead for `StringView` when the key already exists. Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
galou
force-pushed
the
ge/fix/set_stringview
branch
from
7ffe080 to
e892e40
Compare
|
Test case added. |
facontidavide
added a commit
that referenced
this pull request
Jun 7, 2023
|
The problem was real (thanks for reporting), but your solution would have introduced a bug. I fixed it differently here: d28e5be |
|
Thanks for the fix! Just by curiosity and lack of time to study it myself, what was the introduced bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second call to
Blackboard::set()with the same key was not working forStringViewbecauseport_info.parseString(value)returns an emptyAny.Any(std::string(value))is used instead forStringViewwhen the key already exists.