Skip to content

Conversation

Aglargil
Copy link
Contributor

@Aglargil Aglargil commented Feb 10, 2025

#895

  1. feat: add _onStart precondition for script execution
  2. fix covert_impl checkTruncation for CI error

Add a new precondition type _onStart that allows executing scripts
before a node starts its tick. This provides symmetry with the
existing _post functionality.
@Aglargil
Copy link
Contributor Author

Hi, @facontidavide
I've implemented the fixes in the PR, including adding the _onStart precondition and resolving the CI error in covert_impl checkTruncation. If you'd prefer a separate PR for just the CI fix, feel free to let me know—I'm happy to adjust!

@facontidavide
Copy link
Collaborator

@Aglargil I do want to include this, but I can not until I add this precondition to Groot2. Be patient :)

@facontidavide facontidavide self-assigned this Feb 25, 2025
@facontidavide facontidavide added the enhancement New feature or request label Feb 25, 2025
@Aglargil
Copy link
Contributor Author

@Aglargil I do want to include this, but I can not until I add this precondition to Groot2. Be patient :)

Okay, looking forward to your updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BT.CPP-5 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants