Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in clojure-lsp #572

Merged
merged 60 commits into from
Dec 24, 2020
Merged

Bring in clojure-lsp #572

merged 60 commits into from
Dec 24, 2020

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Mar 1, 2020

What has Changed?

  • clojure-lsp is bundled and used
  • clojure.trace.server setting added to set language server log level (off by default)
  • calva.referencesCodeLens.enabled setting added, which turns on/off references code lens (off by default)
  • Calva's ClojureDefinitionProvider disabled in favor of lsp's
  • Lsp formatters disabled in favor of Calva's
  • Lsp code actions disabled
  • Lsp diagnostics disabled in favor of using bundled clj-kondo extension
  • Lsp hover disabled in favor of using Calva's when REPL connections exists, otherwise is enabled
  • Lsp completion item disabled in favor of using Calva's

Some of the things disabled will be added back once the issues are ironed out, like lsp hovers and completion items.

Fixes #571
Resolve #215
Resolve #57
Resolve #612
Resolve #665

I may have missed some other issues this PR will address/close, but it'll take me some time to go through the rest of the issue list. We can close any we come across later manually.

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Made sure I am directing this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I am changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.) You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. (For now you'll need to opt in to the CircleCI New Experience UI to see the Artifacts tab, because bug.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Created the issue I am fixing/addressing, if it was not present.
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

  • Made sure the PR is directed at the dev branch (unless reasons).
  • Read the source changes.
  • Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • If need be, had a chat within the team about particular changes.

Ping @PEZ, @kstehn, @cfehse, @bpringe

@bpringe
Copy link
Member

bpringe commented May 12, 2020

Just want to link a related issue - #57

@ieugen
Copy link
Contributor

ieugen commented Jul 5, 2020

This sounds like a good feature.
Looking forward to it.

@bpringe bpringe changed the title [WIP] Bring in clojure-lsp Bring in clojure-lsp Dec 23, 2020
@bpringe bpringe merged commit ce77855 into dev Dec 24, 2020
@bpringe bpringe deleted the feat/lsp-client branch December 24, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants