Fixed inferring type from a subtype of a state provided for RxState #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The goal of this PR is to fix #177. As provided by the author within his playground demo,
selectSlice
incorrectly infers the type of a slice when the type provided toRxState
declaration is not a concrete type but a generic subtype of one.Example
To verify if the
selectSlice
does what it is supposed to, I created a small example that can be played with even inside our own RxAngular repo.When verifying, please do it also for
strictNullChecks
compiler options set tofalse
. The most problems with type inference come up with this option.