fix(sdk-coin-sol): set correct jito activate instruction indexes #6719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haritkapadia
changed the title
haritkapadia
force-pushed
the
harit/jito-raw-parse-fix
branch
from
86e4db3 to
e869f0a
Compare
evanzbitgo
previously approved these changes
Aug 15, 2025
| const coin = coins.get('tsol'); | ||
| const tx2 = new Transaction(coin); | ||
| tx2.fromRawTransaction(rawTx); | ||
| const tx2Builder = factory.from(rawTx); |
There was a problem hiding this comment.
nit: give a more meaningful name for readability, e.g. rebuiltTxBuilder
There was a problem hiding this comment.
Done.
const builderFromRawTx = factory.from(rawTx);
const rebuiltTx = await builderFromRawTx.build();
rebuiltTx.toJson().instructionsData.should.deepEqual(txJson.instructionsData);
haritkapadia
force-pushed
the
harit/jito-raw-parse-fix
branch
from
e869f0a to
3e113c0
Compare
evanzbitgo
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the instruction index keys used to parse a raw staking activate transaction for Jito.
This PR fixes missing array bounds check in
matchTransactionTypeByInstructionsOrder. microsoft/TypeScript#13778Issue Number
SC-2760
Type of change
How Has This Been Tested?
I updated the Jito staking activate test to include parsing of the raw transaction and comparing it to the original. The equivalent staking deactivate test already performs this comparison.
The array bounds check bug was caught by existing tests.