Skip to content

fix(sdk-coin-sol): set correct jito activate instruction indexes #6719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

fix(sdk-coin-sol): set correct jito activate instruction indexes #6719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ac52b
fix(sdk-coin-sol): set correct jito activate instruction indexes
haritkapadia Aug 15, 2025
3e113c0
fix(sdk-coin-sol): check array bounds for transaction type matching
haritkapadia Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/sdk-coin-sol/src/lib/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export const marinadeStakingActivateInstructionsIndexes = {

/** Const to check the order of the Jito Staking Activate instructions when decode */
export const jitoStakingActivateInstructionsIndexes = {
AtaInit: 0,
InitializeAssociatedTokenAccount: 0,
DepositSol: 1,
} as const;

Expand Down
6 changes: 5 additions & 1 deletion modules/sdk-coin-sol/src/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,11 @@ export function matchTransactionTypeByInstructionsOrder(

// Check instructions by order using the index.
for (const keyName of instructionsKeys) {
const result = getInstructionType(instructionsCopy[instructionIndexes[keyName]]);
const index = instructionIndexes[keyName];
if (index >= instructionsCopy.length) {
return false;
}
const result = getInstructionType(instructionsCopy[index]);
if (result !== keyName) {
return false;
}
Expand Down
7 changes: 3 additions & 4 deletions modules/sdk-coin-sol/test/unit/transactionBuilder/stakingActivateBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,9 @@ describe('Sol Staking Activate Builder', () => {
const rawTx = tx.toBroadcastFormat();
should.equal(Utils.isValidRawTransaction(rawTx), true);
should.equal(rawTx, testData.JITO_STAKING_ACTIVATE_SIGNED_TX);
factory.from(testData.JITO_STAKING_ACTIVATE_SIGNED_TX);
const coin = coins.get('tsol');
const tx2 = new Transaction(coin);
tx2.fromRawTransaction(rawTx);
const builderFromRawTx = factory.from(rawTx);
const rebuiltTx = await builderFromRawTx.build();
rebuiltTx.toJson().instructionsData.should.deepEqual(txJson.instructionsData);
});

it('build a create and delegate staking signed tx with memo', async () => {
Expand Down
Loading