ci: use lts/* to describe Node.js version #76
Conversation
With this indirection, we can configure a required status check that doesn't require updating when Node.js LTS versions change. (The matrix version appears in the name of the status check, this was the least-gross workaround I could find. Peer here for some horror shows: https://github.community/t/status-check-for-a-matrix-jobs/127354/11)
|
Success! We can see in the name of the status check now that we aren't describing a numeric Node.js version: |
| key: turbo-${{ matrix.node-version }}-${{ github.ref_name }}-${{ github.job }}-${{ github.sha }} | ||
| key: | ||
| turbo-${{ matrix.node-version }}-${{ github.ref_name }}-${{ github.job | ||
| }}-${{ github.sha }} |
There was a problem hiding this comment.
Was this an auto formatting thing? This could potentially break caching.
There was a problem hiding this comment.
Okay this build looks like it used the intended key despite this line break being added: https://github.com/BitGo/api-ts/runs/6430577428?check_suite_focus=true#step:14:5
🤷♂️
There was a problem hiding this comment.
hmmm yes it must have been 😰
that is oddly terrifying indeed. Maybe if we wrap the value in quotes it won't wrap?
There was a problem hiding this comment.
No go, still wraps
|
🎉 This PR is included in version 1.0.0-beta.10 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.6 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.2 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.2.0-beta.6 🎉 The release is available on npm package (@beta dist-tag) Your semantic-release bot 📦🚀 |
With this indirection, we can configure a required status check that
doesn't require updating when Node.js LTS versions change.
(The matrix version appears in the name of the
status check, this was the least-gross workaround
I could find. Peer here for some horror shows:
https://github.community/t/status-check-for-a-matrix-jobs/127354/11)