Skip to content

ci: use lts/* to describe Node.js version #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2022
Merged

ci: use lts/* to describe Node.js version #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:

strategy:
matrix:
node-version: ['12', '14', '16']
node-version: ['12', '14', 'lts/*']

name: Node.js ${{ matrix.node-version }}
steps:
Expand All @@ -35,7 +35,9 @@ jobs:
uses: actions/cache@v3
with:
path: node_modules/.cache
key: turbo-${{ matrix.node-version }}-${{ github.ref_name }}-${{ github.job }}-${{ github.sha }}
key:
turbo-${{ matrix.node-version }}-${{ github.ref_name }}-${{ github.job
}}-${{ github.sha }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this an auto formatting thing? This could potentially break caching.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this build looks like it used the intended key despite this line break being added: https://github.com/BitGo/api-ts/runs/6430577428?check_suite_focus=true#step:14:5

🤷‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm yes it must have been 😰

that is oddly terrifying indeed. Maybe if we wrap the value in quotes it won't wrap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No go, still wraps

# According to GitHub documentation, only keys generated by the PR branch and the target branch are considered. This is
# to prevent a malicious PR from manipulating the cache to inject malicious code into unrelated branches.
# See: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#matching-a-cache-key
Expand Down