Skip to content

Conversation

TimOsahenru
Copy link
Contributor

Issue Link 🔗:

Issue: #553

Type of Change

  • Bug fix 🐞
  • New feature/page
  • Documentation update
  • Other

Description 📋

  • Made the carousel width 100% so it can match with the rest section of the page
  • Changed circled image to display full image
  • Used custom built carousel and uninstalled bootstrap
  • Included two testcases to test the implementation of the carousel slider
    • to test the carousel actually is exist on the page
    • to the test the first item from the carousel and that from the last post section matches

Checklist ✅

  • Followed the Code of Conduct and Contribution Guide
  • Ran pre-commit run --all
  • All tests pass locally
  • Added tests (if applicable)
  • Documentation updated (if applicable)

Additional Notes & Screenshots

Commented out this section out from our testcase in other to de-emphasize that section

      def test_page_description_in_index_and_blog(page_url: tuple[Page, str], url: str):
          """Checks for the descriptions data in the blog posts. There should be some objects with the class `post-description`"""
          page, live_server_url = page_url
          page.goto(f"{live_server_url}{url}")
          expect(page.locator("p.post-description").first).to_be_visible()
          expect(page.locator("p.post-description").first).not_to_be_empty()

since the post description tag has been removed from the index page

dependabot bot and others added 30 commits October 29, 2024 04:24
Bumps [json](https://github.com/ruby/json) from 2.7.2 to 2.7.4.
- [Release notes](https://github.com/ruby/json/releases)
- [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md)
- [Commits](ruby/json@v2.7.2...v2.7.4)

---
updated-dependencies:
- dependency-name: json
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [execjs](https://github.com/rails/execjs) from 2.9.1 to 2.10.0.
- [Release notes](https://github.com/rails/execjs/releases)
- [Commits](rails/execjs@v2.9.1...v2.10.0)

---
updated-dependencies:
- dependency-name: execjs
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…thonDevs#549)

Bumps [activesupport](https://github.com/rails/rails) from 7.2.1.1 to 7.2.1.2.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.2.1.2/activesupport/CHANGELOG.md)
- [Commits](rails/rails@v7.2.1.1...v7.2.1.2)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.8 to 3.3.9.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.3.8...v3.3.9)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* creating recap post for pyconug

- Added 3 images to the images folder in the assets directory.
- Added post in the _posts folder on 2024-10-25

* Fix table display

* Reformat post

- Remove paragraph HTML tags
- Replace Markdown table with HTML table

* Update _posts/2024-10-25-pycon-ug-2024.md

Co-authored-by: Jay Miller <kjaymiller@gmail.com>

* replace featured image with BPD's one

* fix pre-commit issues

---------

Co-authored-by: Jay Miller <kjaymiller@gmail.com>
Bumps [json](https://github.com/ruby/json) from 2.7.4 to 2.7.6.
- [Release notes](https://github.com/ruby/json/releases)
- [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md)
- [Commits](ruby/json@v2.7.4...v2.7.6)

---
updated-dependencies:
- dependency-name: json
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webrick](https://github.com/ruby/webrick) from 1.8.2 to 1.9.0.
- [Release notes](https://github.com/ruby/webrick/releases)
- [Commits](ruby/webrick@v1.8.2...v1.9.0)

---
updated-dependencies:
- dependency-name: webrick
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…onDevs#560)

Bumps [activesupport](https://github.com/rails/rails) from 7.2.1.2 to 7.2.2.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v7.2.2/activesupport/CHANGELOG.md)
- [Commits](rails/rails@v7.2.1.2...v7.2.2)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…generate-post-descriptions

556 auto generate post descriptions
TimOsahenru and others added 18 commits November 9, 2024 03:30
Bumps [uri](https://github.com/ruby/uri) from 0.13.1 to 1.0.1.
- [Release notes](https://github.com/ruby/uri/releases)
- [Commits](ruby/uri@v0.13.1...v1.0.1)

---
updated-dependencies:
- dependency-name: uri
  dependency-type: indirect
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Bumps [net-http](https://github.com/ruby/net-http) from 0.4.1 to 0.5.0.
- [Release notes](https://github.com/ruby/net-http/releases)
- [Commits](ruby/net-http@v0.4.1...v0.5.0)

---
updated-dependencies:
- dependency-name: net-http
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…evs#570)

Bumps [securerandom](https://github.com/ruby/securerandom) from 0.3.1 to 0.3.2.
- [Release notes](https://github.com/ruby/securerandom/releases)
- [Commits](ruby/securerandom@v0.3.1...v0.3.2)

---
updated-dependencies:
- dependency-name: securerandom
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#571)

Bumps [benchmark](https://github.com/ruby/benchmark) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/ruby/benchmark/releases)
- [Commits](ruby/benchmark@v0.3.0...v0.4.0)

---
updated-dependencies:
- dependency-name: benchmark
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…Devs#572)

Bumps [activesupport](https://github.com/rails/rails) from 7.2.2 to 8.0.0.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v8.0.0/activesupport/CHANGELOG.md)
- [Commits](rails/rails@v7.2.2...v8.0.0)

---
updated-dependencies:
- dependency-name: activesupport
  dependency-type: indirect
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [json](https://github.com/ruby/json) from 2.7.6 to 2.8.1.
- [Release notes](https://github.com/ruby/json/releases)
- [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md)
- [Commits](ruby/json@v2.7.6...v2.8.1)

---
updated-dependencies:
- dependency-name: json
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [uri](https://github.com/ruby/uri) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/ruby/uri/releases)
- [Commits](ruby/uri@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: uri
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…honDevs#584)

Bumps [faraday-net_http](https://github.com/lostisland/faraday-net_http) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/lostisland/faraday-net_http/releases)
- [Commits](lostisland/faraday-net_http@v3.3.0...v3.4.0)

---
updated-dependencies:
- dependency-name: faraday-net_http
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [json](https://github.com/ruby/json) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/ruby/json/releases)
- [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md)
- [Commits](ruby/json@v2.8.1...v2.8.2)

---
updated-dependencies:
- dependency-name: json
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@TimOsahenru
Copy link
Contributor Author

@kjaymiller please help review this. Thanks

@kjaymiller kjaymiller added the design_change triggers the generate_screenshot workflow label Nov 25, 2024
@kjaymiller
Copy link
Contributor

Going to add this to the new carousel branch for now - There is still a couple tweaks to figure out.

  • Make images full width with cutoff overflow
    screenshot of carousel with black bars on the side

  • Move sections into a split grid together

Screenshot on homepage with the blog posts and join sections being full-width

@kjaymiller kjaymiller changed the base branch from gh-pages to New-Carousel November 25, 2024 04:02
@kjaymiller kjaymiller merged commit 5ee4663 into BlackPythonDevs:New-Carousel Nov 25, 2024
3 checks passed
@TimOsahenru
Copy link
Contributor Author

Working on it. Thanks

@TimOsahenru
Copy link
Contributor Author

Hello @kjaymiller I have made the changes to this branch #586 for de-emphasizing the latest post and join us section.

@TimOsahenru
Copy link
Contributor Author

Also made changes to this branch #587 to fix the full image issue with the slider

@TimOsahenru TimOsahenru deleted the new-carousel branch March 21, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design_change triggers the generate_screenshot workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants