introduce specific interfaces for local and session storage #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the CI server doesn't have the latest .Net Core 3 SDK installed. |
|
@galvesribeiro Any chance you could review these? I would like to use these interfaces in my own code for unit testing. |
galvesribeiro
requested changes
Nov 23, 2019
There was a problem hiding this comment.
Hey! It looks good to me. However, in order to make the CI to work, please update the ci.yaml and publish.yaml files to reflect the SDK version.
Both files has an entry like the one here where we set up the .Net Core SDK.
Once this got sorted I'll merge it.
Thanks!
|
Hey! Sorry for the delay. Please fix the comments on the review and we should be good to merge it. |
galvesribeiro
requested changes
Nov 23, 2019
galvesribeiro
requested changes
Nov 23, 2019
galvesribeiro
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.