Skip to content

introduce specific interfaces for local and session storage #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 23, 2019
Merged

introduce specific interfaces for local and session storage #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d90a5d2
update nuget packages
celluj34 Nov 15, 2019
a5d5e77
introduce interfaces for specific storage implementations
celluj34 Nov 15, 2019
4cf1c36
use new interfaces and make the implementations internal
celluj34 Nov 15, 2019
61479a5
register the implementation with the new interfaces
celluj34 Nov 15, 2019
998faaa
fix blazor using internal classes
celluj34 Nov 15, 2019
d3910aa
update dotnet version for ci and publish
celluj34 Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v1
with:
dotnet-version: 3.1.100-preview1-014459
dotnet-version: 3.1.100-preview3-014645
- name: Build
run: dotnet build --configuration Release
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v1
with:
dotnet-version: 3.1.100-preview1-014459
dotnet-version: 3.1.100-preview3-014645
- name: Build
run: dotnet build --configuration Release
- name: Pack
Expand Down
2 changes: 1 addition & 1 deletion src/Blazor.Extensions.Storage/Blazor.Extensions.Storage.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="3.1.0-preview1.19508.20" />
<PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="3.1.0-preview3.19555.2" />
</ItemGroup>

<ItemGroup>
Expand Down
4 changes: 4 additions & 0 deletions src/Blazor.Extensions.Storage/Interfaces/ILocalStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
namespace Blazor.Extensions.Storage.Interfaces
{
public interface ILocalStorage : IStorage {}
}
4 changes: 4 additions & 0 deletions src/Blazor.Extensions.Storage/Interfaces/ISessionStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
namespace Blazor.Extensions.Storage.Interfaces
{
public interface ISessionStorage : IStorage {}
}
2 changes: 1 addition & 1 deletion src/Blazor.Extensions.Storage/LocalStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Blazor.Extensions.Storage
{
public class LocalStorage : IStorage
internal class LocalStorage : ILocalStorage
{
private readonly IJSRuntime runtime;

Expand Down
2 changes: 1 addition & 1 deletion src/Blazor.Extensions.Storage/SessionStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Blazor.Extensions.Storage
{
public class SessionStorage : IStorage
internal class SessionStorage : ISessionStorage
{
private readonly IJSRuntime runtime;

Expand Down
5 changes: 3 additions & 2 deletions src/Blazor.Extensions.Storage/StorageExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using Blazor.Extensions.Storage.Interfaces;
using Microsoft.Extensions.DependencyInjection;

namespace Blazor.Extensions.Storage
Expand All @@ -6,8 +7,8 @@ public static class StorageExtensions
{
public static IServiceCollection AddStorage(this IServiceCollection services)
{
return services.AddScoped<SessionStorage>()
.AddScoped<LocalStorage>();
return services.AddScoped<ISessionStorage, SessionStorage>()
.AddScoped<ILocalStorage, LocalStorage>();
}
}
}
8 changes: 4 additions & 4 deletions test/Blazor.Extensions.Storage.Test/Blazor.Extensions.Storage.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Blazor" Version="3.1.0-preview1.19508.20" />
<PackageReference Include="Microsoft.AspNetCore.Blazor.Build" Version="3.1.0-preview1.19508.20" PrivateAssets="all" />
<PackageReference Include="Microsoft.AspNetCore.Blazor.DevServer" Version="3.1.0-preview1.19508.20" PrivateAssets="all" />
<PackageReference Include="Microsoft.AspNetCore.Blazor.HttpClient" Version="3.1.0-preview1.19508.20" />
<PackageReference Include="Microsoft.AspNetCore.Blazor" Version="3.1.0-preview3.19555.2" />
<PackageReference Include="Microsoft.AspNetCore.Blazor.Build" Version="3.1.0-preview3.19555.2" PrivateAssets="all" />
<PackageReference Include="Microsoft.AspNetCore.Blazor.DevServer" Version="3.1.0-preview3.19555.2" PrivateAssets="all" />
<PackageReference Include="Microsoft.AspNetCore.Blazor.HttpClient" Version="3.1.0-preview3.19555.2" />
</ItemGroup>

<ItemGroup>
Expand Down
5 changes: 3 additions & 2 deletions test/Blazor.Extensions.Storage.Test/Pages/Index.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
@page "/"
@inject SessionStorage SessionStorage
@inject LocalStorage LocalStorage
@inject ISessionStorage SessionStorage
@inject ILocalStorage LocalStorage
@inject HttpClient Http
@inject InteropStorage InteropStorage
@inject IJSRuntime JSRuntime
@using Blazor.Extensions.Storage.Interfaces
@using Blazor.Extensions.Storage.Test.Interop

<h1>Test logging output: (See debugger log for full output)</h1>
Expand Down