Remove deprecated viewer module #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +28,4 @@ | |||
|
|
|||
| """View tools to visualize morphologies.""" | |||
| from neurom.view.matplotlib_impl import (plot_morph, plot_morph3d, | |||
| plot_tree, plot_tree3d, | |||
There was a problem hiding this comment.
@mgeplf , just to verify after our discussion, we do want to hide these. right?
There was a problem hiding this comment.
I don't really see their utility, but on the other hand, they're part of the API, and someone may have used them.
I guess we have 3 choices:
- Leave things how they are
- Mark them as deprecated, and remove them later
- Remove them now, explain in Changelog that they just aren't as visible, and to give feedback if they are needed.
I think 3 is a fine compromise, what do you think?
There was a problem hiding this comment.
yeah, I agree
There was a problem hiding this comment.
I believe this is good to go now, right?
Codecov Report
@@ Coverage Diff @@
## v4 #1032 +/- ##
======================================
Coverage ? 100.00%
======================================
Files ? 35
Lines ? 2457
Branches ? 0
======================================
Hits ? 2457
Misses ? 0
Partials ? 0 |
mgeplf
approved these changes
May 3, 2022
eleftherioszisis
added a commit
that referenced
this pull request
Jun 7, 2022
Removes viewer deprecated module and hides plot_tree, plot_tree3d, plot_soma, plot_soma3d from neurom.view Co-authored-by: Zisis Eleftherios <zisis@bb-fvfd24cfmnhx.epfl.ch>
eleftherioszisis
pushed a commit
that referenced
this pull request
May 14, 2024
* Mixed subtree processing (#981) * Refactor tests for test_mixed.py (#1027) * Remove deprecated modules and functions/classes & warnings (#1026, #1032) * Use readonly morphio Morphology by default (#979) * Morphology level radial distance features use the soma as reference point (#1030) * Expose subtree processing from the morph_stats api (#1034) * Remove pyXX prefix for lint, docs, and coverage (#1038) * Fix tutorials and add tutorial testenv (#1039) * Add isort for formatting/linting (#1040) * Add testing of example scripts (#1041) * Make documentation/docstrings testable (#1035) * Add black to neurom, format everything, and add to lint (#1042) * Fix load_morpholgies to always resolve paths (#1047) * allow Morphology objects to be either mut or immut (#1049) * Replace iter_* methods by properties in core objects and improve iter_segments (#1054) * Decouple Morphology constructor from io (#1120) * Move soma methods to functions (#1118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.