Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black to neurom, format everything, and add to lint #1042

Merged
merged 5 commits into from
Jun 7, 2022

Conversation

eleftherioszisis
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v4@367544e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7683a97 differs from pull request most recent head b7f52b9. Consider uploading reports for the commit b7f52b9 to get more accurate results

@@          Coverage Diff           @@
##             v4     #1042   +/-   ##
======================================
  Coverage      ?   100.00%           
======================================
  Files         ?        35           
  Lines         ?      2471           
  Branches      ?         0           
======================================
  Hits          ?      2471           
  Misses        ?         0           
  Partials      ?         0           

@eleftherioszisis eleftherioszisis requested review from adrien-berchet and mgeplf and removed request for adrien-berchet May 24, 2022 15:08
Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :)

@@ -35,8 +37,10 @@ commands =
basepython=python3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add skip_install = true in this section.

@mgeplf
Copy link
Collaborator

mgeplf commented May 25, 2022

GIthub turned on handling of .git-blame-ignore-revs (https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-view-beta/), so we'll add the commit there, once it has a stable hash

Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's allow single quotes w/ --skip-string-normalization, and rerun the format.

@eleftherioszisis eleftherioszisis force-pushed the zisis/paint-it-black branch 2 times, most recently from 84fb851 to fb62818 Compare May 25, 2022 08:56
@eleftherioszisis
Copy link
Contributor Author

@mgeplf is it good now?

@eleftherioszisis eleftherioszisis merged commit 94f79e5 into v4 Jun 7, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/paint-it-black branch June 7, 2022 07:11
@adrien-berchet adrien-berchet added this to the v4 milestone Feb 22, 2023
eleftherioszisis pushed a commit that referenced this pull request May 14, 2024
* Mixed subtree processing (#981)
* Refactor tests for test_mixed.py (#1027)
* Remove deprecated modules and functions/classes & warnings (#1026, #1032)
* Use readonly morphio Morphology by default (#979)
* Morphology level radial distance features use the soma as reference point (#1030)
* Expose subtree processing from the morph_stats api (#1034)
* Remove pyXX prefix for lint, docs, and coverage (#1038)
* Fix tutorials and add tutorial testenv (#1039)
* Add isort for formatting/linting (#1040)
* Add testing of example scripts (#1041)
* Make documentation/docstrings testable (#1035)
* Add black to neurom, format everything, and add to lint (#1042)
* Fix load_morpholgies to always resolve paths (#1047)
* allow Morphology objects to be either mut or immut (#1049)
* Replace iter_* methods by properties in core objects and improve iter_segments (#1054)
* Decouple Morphology constructor from io (#1120)
* Move soma methods to functions (#1118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants