Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make documentation/docstrings testable #1035

Merged
merged 15 commits into from
Jun 7, 2022
Merged

Make documentation/docstrings testable #1035

merged 15 commits into from
Jun 7, 2022

Conversation

eleftherioszisis
Copy link
Collaborator

@eleftherioszisis eleftherioszisis commented May 10, 2022

  • Turn most of code snippets into testable code.
  • sphinx doctest checks docstrings and documentation for testable code

doc/source/features.rst Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v4@08270b2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b5cda23 differs from pull request most recent head 9765136. Consider uploading reports for the commit 9765136 to get more accurate results

@@          Coverage Diff           @@
##             v4     #1035   +/-   ##
======================================
  Coverage      ?   100.00%           
======================================
  Files         ?        35           
  Lines         ?      2469           
  Branches      ?         0           
======================================
  Hits          ?      2469           
  Misses        ?         0           
  Partials      ?         0           

tox.ini Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@eleftherioszisis
Copy link
Collaborator Author

Are there any further comments on this, or may I merge it?

@mgeplf
Copy link
Collaborator

mgeplf commented Jun 1, 2022

LGTM

doc/source/developer.rst Outdated Show resolved Hide resolved
doc/source/examples.rst Outdated Show resolved Hide resolved
doc/source/examples.rst Outdated Show resolved Hide resolved
doc/source/examples.rst Show resolved Hide resolved
doc/source/features.rst Show resolved Hide resolved
eleftherioszisis and others added 3 commits June 6, 2022 15:44
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
@eleftherioszisis eleftherioszisis merged commit 367544e into v4 Jun 7, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/doctest branch June 7, 2022 06:54
eleftherioszisis pushed a commit that referenced this pull request May 14, 2024
* Mixed subtree processing (#981)
* Refactor tests for test_mixed.py (#1027)
* Remove deprecated modules and functions/classes & warnings (#1026, #1032)
* Use readonly morphio Morphology by default (#979)
* Morphology level radial distance features use the soma as reference point (#1030)
* Expose subtree processing from the morph_stats api (#1034)
* Remove pyXX prefix for lint, docs, and coverage (#1038)
* Fix tutorials and add tutorial testenv (#1039)
* Add isort for formatting/linting (#1040)
* Add testing of example scripts (#1041)
* Make documentation/docstrings testable (#1035)
* Add black to neurom, format everything, and add to lint (#1042)
* Fix load_morpholgies to always resolve paths (#1047)
* allow Morphology objects to be either mut or immut (#1049)
* Replace iter_* methods by properties in core objects and improve iter_segments (#1054)
* Decouple Morphology constructor from io (#1120)
* Move soma methods to functions (#1118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants